From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, Johan Hovold <johan@kernel.org>
Subject: Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling
Date: Wed, 7 Sep 2022 23:02:34 +0530 [thread overview]
Message-ID: <20220907173234.GA539582@thinkpad> (raw)
In-Reply-To: <20220901091527.1992208-1-dmitry.baryshkov@linaro.org>
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote:
> Johan Hovold has reported that returning a probe deferral from the
> msm_dp_modeset_init() can cause issues because the IRQ is not freed
> properly. This (compile-tested only) series tries to fix the issue by
> moving devm_request_irq() to the probe callback.
>
This series fixes the probe deferral issue on Lenovo Thinkpad X13s. But I
didn't look close enough to verify if all other resource deallocation are just
fine.
Thanks for the quick series, Dmitry!
Regards,
Mani
> Dmitry Baryshkov (3):
> drm/msm/dp: fold disable_irq into devm_request_irq
> drm/msm/dp: switch to using platform_get_irq()
> drm/msm/dp: move dp_request_irq() call to dp_display_probe()
>
> drivers/gpu/drm/msm/dp/dp_display.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-09-07 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 9:15 [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling Dmitry Baryshkov
2022-09-01 9:15 ` [RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq Dmitry Baryshkov
2022-09-08 0:33 ` Stephen Boyd
2022-09-01 9:15 ` [RFC PATCH 2/3] drm/msm/dp: switch to using platform_get_irq() Dmitry Baryshkov
2022-09-08 0:40 ` Stephen Boyd
2022-09-01 9:15 ` [RFC PATCH 3/3] drm/msm/dp: move dp_request_irq() call to dp_display_probe() Dmitry Baryshkov
2022-09-08 0:42 ` Stephen Boyd
2022-09-01 9:20 ` [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling Johan Hovold
2022-09-01 9:21 ` Dmitry Baryshkov
2022-09-01 9:28 ` Johan Hovold
2022-09-07 17:32 ` Manivannan Sadhasivam [this message]
2022-09-13 9:44 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907173234.GA539582@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox