Re: [PATCH v3 1/2] dt-bindings: dma: rework qcom,adm Documentation to yaml schema

Christian Marangi
2022-09-14T16:57:38Z

On Wed, Sep 14, 2022 at 11:47:10AM -0500, Rob Herring wrote:
> On Wed, 14 Sep 2022 16:04:25 +0200, Christian Marangi wrote:
> > Rework the qcom,adm Documentation to yaml schema.
> > This is not a pure conversion since originally the driver has changed
> > implementation for the #dma-cells and was wrong from the start.
> > Also the driver now handles the common DMA clients implementation with
> > the first cell that denotes the channel number and nothing else since
> > the client will have to provide the crci information via other means.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > .../devicetree/bindings/dma/qcom,adm.yaml | 96 +++++++++++++++++++
> > .../devicetree/bindings/dma/qcom_adm.txt | 61 ------------
> > 2 files changed, 96 insertions(+), 61 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/dma/qcom,adm.yaml
> > delete mode 100644 Documentation/devicetree/bindings/dma/qcom_adm.txt
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> dma-controller@18300000: reset-names:1: 'c0' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names:2: 'c1' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names:3: 'c2' was expected
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: reset-names: ['clk', 'pbus', 'c0', 'c1', 'c2'] is too long
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>
> dma-controller@18300000: resets: [[12, 13], [12, 12], [12, 11], [12, 10], [12, 9]] is too long
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
>

Hi,
I fixed these warning on the second commit of this series.

--
Ansuel