From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653AAC6FA82 for ; Fri, 16 Sep 2022 19:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229455AbiIPTHG (ORCPT ); Fri, 16 Sep 2022 15:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbiIPTHF (ORCPT ); Fri, 16 Sep 2022 15:07:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4997FA6C0B; Fri, 16 Sep 2022 12:07:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E8CB5B828FF; Fri, 16 Sep 2022 19:07:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B44EEC433D6; Fri, 16 Sep 2022 19:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663355221; bh=uVb/OpxkjxZvGpMjJCBUfOYKFcSN1A5P5jgb3RoZdEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QRpf35OSJJIk1lN/3zpnesC5MPYXphUvNSRJecsPVUHfKokyS3NRtamGLjdokI63F AMDSYmprvNrPbT9YpPCUHLdf6HYr4UCIr3zm1iydITRAd/pJZGnWxFtCv3V+j+QbPR 2gDx3XZIQ5gomf9KP5VNtbC2+Q4T4UlAeg39QIlUe2g49wxfccBh+zdmFsoga5VzuF xVs4uFetUhSTpU58/aEWjhuopsELN22Mkwz2PFGKBOEPSzlqYosdACTfGzZgm5o/XE P4uQGaHsBPVxTdT9gWq6Zo/ONXDCkT48df0DKdmQbWZ3sHhijtFW8OqxYtwpnop+1o wk/6tzw/9bXsA== Date: Fri, 16 Sep 2022 14:06:58 -0500 From: Bjorn Andersson To: Rajendra Nayak Cc: agross@kernel.org, konrad.dybcio@somainline.org, mturquette@baylibre.com, sboyd@kernel.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, quic_kriskura@quicinc.com, dianders@chromium.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 2/3] clk: qcom: gcc-sc7180: Update the .pwrsts for usb gdsc Message-ID: <20220916190658.2g7hegdkl6efda6r@builder.lan> References: <20220916102417.24549-1-quic_rjendra@quicinc.com> <20220916102417.24549-2-quic_rjendra@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916102417.24549-2-quic_rjendra@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Sep 16, 2022 at 03:54:16PM +0530, Rajendra Nayak wrote: > The USB controller on sc7180 does not retain the state when > the system goes into low power state and the GDSC is > turned off. This results in the controller reinitializing and > re-enumerating all the connected devices (resulting in additional > delay while coming out of suspend) > Fix this by updating the .pwrsts for the USB GDSC so it only > transitions to retention state in low power. > > Signed-off-by: Rajendra Nayak > Reviewed-by: Matthias Kaehlcke > Tested-by: Matthias Kaehlcke > --- > v2: > Updated the changelog > > drivers/clk/qcom/gcc-sc7180.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c > index c2ea09945c47..2d3980251e78 100644 > --- a/drivers/clk/qcom/gcc-sc7180.c > +++ b/drivers/clk/qcom/gcc-sc7180.c > @@ -2224,7 +2224,7 @@ static struct gdsc usb30_prim_gdsc = { > .pd = { > .name = "usb30_prim_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, I presume the same should be applied to gcc_usb30_sec_gdsc? Regards, Bjorn > }; > > static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = { > -- > 2.17.1 >