From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: mka@chromium.org, evgreen@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/8] net: ipa: don't use u32p_replace_bits()
Date: Thu, 22 Sep 2022 17:20:53 -0500 [thread overview]
Message-ID: <20220922222100.2543621-2-elder@linaro.org> (raw)
In-Reply-To: <20220922222100.2543621-1-elder@linaro.org>
In two spots we use u32_replace_bits() to replace a set of bits in a
register while preserving the rest. Both of those cases just zero
the bits being replaced, and this can be done more simply without
using that function.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_table.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c
index 69efe672ca528..037cec2fd5942 100644
--- a/drivers/net/ipa/ipa_table.c
+++ b/drivers/net/ipa/ipa_table.c
@@ -524,7 +524,7 @@ static void ipa_filter_tuple_zero(struct ipa_endpoint *endpoint)
val = ioread32(endpoint->ipa->reg_virt + offset);
/* Zero all filter-related fields, preserving the rest */
- u32p_replace_bits(&val, 0, IPA_REG_ENDP_FILTER_HASH_MSK_ALL);
+ val &= ~IPA_REG_ENDP_FILTER_HASH_MSK_ALL;
iowrite32(val, endpoint->ipa->reg_virt + offset);
}
@@ -571,7 +571,7 @@ static void ipa_route_tuple_zero(struct ipa *ipa, u32 route_id)
val = ioread32(ipa->reg_virt + offset);
/* Zero all route-related fields, preserving the rest */
- u32p_replace_bits(&val, 0, IPA_REG_ENDP_ROUTER_HASH_MSK_ALL);
+ val &= ~IPA_REG_ENDP_ROUTER_HASH_MSK_ALL;
iowrite32(val, ipa->reg_virt + offset);
}
--
2.34.1
next prev parent reply other threads:[~2022-09-22 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 22:20 [PATCH net-next 0/8] net: ipa: another set of cleanups Alex Elder
2022-09-22 22:20 ` Alex Elder [this message]
2022-09-22 22:20 ` [PATCH net-next 2/8] net: ipa: introduce ipa_qtime_val() Alex Elder
2022-09-22 22:20 ` [PATCH net-next 3/8] net: ipa: rearrange functions for similarity Alex Elder
2022-09-22 22:20 ` [PATCH net-next 4/8] net: ipa: define BCR values using an enum Alex Elder
2022-09-22 22:20 ` [PATCH net-next 5/8] net: ipa: tidy up register enum definitions Alex Elder
2022-09-22 22:20 ` [PATCH net-next 6/8] net: ipa: encapsulate setting the FILT_ROUT_HASH_EN register Alex Elder
2022-09-22 22:20 ` [PATCH net-next 7/8] net: ipa: encapsulate updating the COUNTER_CFG register Alex Elder
2022-09-22 22:21 ` [PATCH net-next 8/8] net: ipa: encapsulate updating three more registers Alex Elder
2022-09-24 4:10 ` [PATCH net-next 0/8] net: ipa: another set of cleanups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922222100.2543621-2-elder@linaro.org \
--to=elder@linaro.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox