Re: [PATCH v3 18/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config

Stephan Gerhold
2022-09-28T18:10:59Z

On Tue, Sep 27, 2022 at 07:36:46PM +0200, Krzysztof Kozlowski wrote:
> The TLMM pin controller follows generic pin-controller bindings, so
> should have subnodes with '-state' and '-pins'. Otherwise the subnodes
> (level one and two) are not properly matched. This method also unifies
> the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
> .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> index e03530091478..b1735918fa90 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> @@ -43,8 +43,9 @@ patternProperties:
> oneOf:
> - $ref: "#/$defs/qcom-msm8909-tlmm-state"
> - patternProperties:
> - ".*":
> + "-pins$":
> $ref: "#/$defs/qcom-msm8909-tlmm-state"
> + additionalProperties: false
>
> $defs:
> qcom-msm8909-tlmm-state:
> @@ -136,13 +137,13 @@ examples:
> };
>
> uart-w-subnodes-state {
> - rx {
> + rx-pins {
> pins = "gpio4";
> function = "blsp_uart1";
> bias-pull-up;
> };
>
> - tx {
> + tx-pins {
> pins = "gpio5";
> function = "blsp_uart1";
> bias-disable;
> --
> 2.34.1
>