* [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 [not found] <20221009234932.1230196-1-sashal@kernel.org> @ 2022-10-09 23:49 ` Sasha Levin 2022-10-10 23:43 ` Richard Acayan 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2022-10-09 23:49 UTC (permalink / raw) To: linux-kernel, stable Cc: Richard Acayan, Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, Sasha Levin, agross, andersson, adrian.hunter, linux-arm-msm, linux-mmc From: Richard Acayan <mailingradian@gmail.com> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ] The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to restore the dll config). Add a compatible string check to detect the need for this. Signed-off-by: Richard Acayan <mailingradian@gmail.com> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index dc2991422a87..3a091a387ecb 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { */ {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, {}, -- 2.35.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 2022-10-09 23:49 ` [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 Sasha Levin @ 2022-10-10 23:43 ` Richard Acayan 2022-10-13 17:59 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Richard Acayan @ 2022-10-10 23:43 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Richard Acayan, Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, agross, andersson, adrian.hunter, linux-arm-msm, linux-mmc > From: Richard Acayan <mailingradian@gmail.com> > > [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ] > > The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to > restore the dll config). Add a compatible string check to detect the need > for this. > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/mmc/host/sdhci-msm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index dc2991422a87..3a091a387ecb 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { > */ > {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, > {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, > + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, Supporting device trees which are invalid under 6.0 schema? It's not a bug fix, it's a feature. Documentation/devicetree/bindings/mmc/sdhci-msm.yaml:17-49, at tag v6.0: properties: compatible: oneOf: - enum: - qcom,sdhci-msm-v4 deprecated: true - items: - enum: - qcom,apq8084-sdhci - qcom,msm8226-sdhci - qcom,msm8953-sdhci - qcom,msm8974-sdhci - qcom,msm8916-sdhci - qcom,msm8992-sdhci - qcom,msm8994-sdhci - qcom,msm8996-sdhci - qcom,msm8998-sdhci - const: qcom,sdhci-msm-v4 # for sdcc versions less than 5.0 - items: - enum: - qcom,qcs404-sdhci - qcom,sc7180-sdhci - qcom,sc7280-sdhci - qcom,sdm630-sdhci - qcom,sdm845-sdhci - qcom,sdx55-sdhci - qcom,sdx65-sdhci - qcom,sm6125-sdhci - qcom,sm6350-sdhci - qcom,sm8150-sdhci - qcom,sm8250-sdhci - qcom,sm8450-sdhci - const: qcom,sdhci-msm-v5 # for sdcc version 5.0 I'm new to this, so I apologize if I don't understand stable kernel development. > {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, > {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, > {}, > -- > 2.35.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 2022-10-10 23:43 ` Richard Acayan @ 2022-10-13 17:59 ` Sasha Levin 2022-10-14 0:37 ` Richard Acayan 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2022-10-13 17:59 UTC (permalink / raw) To: Richard Acayan Cc: linux-kernel, stable, Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, agross, andersson, adrian.hunter, linux-arm-msm, linux-mmc On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote: >> From: Richard Acayan <mailingradian@gmail.com> >> >> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ] >> >> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to >> restore the dll config). Add a compatible string check to detect the need >> for this. >> >> Signed-off-by: Richard Acayan <mailingradian@gmail.com> >> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> Signed-off-by: Sasha Levin <sashal@kernel.org> >> --- >> drivers/mmc/host/sdhci-msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index dc2991422a87..3a091a387ecb 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { >> */ >> {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, >> {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, >> + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, > >Supporting device trees which are invalid under 6.0 schema? It's not a bug fix, >it's a feature. Does this not enable hardware to work properly? We take quirks/device enablement into stable tree as well. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 2022-10-13 17:59 ` Sasha Levin @ 2022-10-14 0:37 ` Richard Acayan 0 siblings, 0 replies; 4+ messages in thread From: Richard Acayan @ 2022-10-14 0:37 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, agross, andersson, adrian.hunter, linux-arm-msm, linux-mmc > On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote: >>> From: Richard Acayan <mailingradian@gmail.com> >>> >>> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ] >>> >>> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to >>> restore the dll config). Add a compatible string check to detect the need >>> for this. >>> >>> Signed-off-by: Richard Acayan <mailingradian@gmail.com> >>> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com >>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >>> Signed-off-by: Sasha Levin <sashal@kernel.org> >>> --- >>> drivers/mmc/host/sdhci-msm.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >>> index dc2991422a87..3a091a387ecb 100644 >>> --- a/drivers/mmc/host/sdhci-msm.c >>> +++ b/drivers/mmc/host/sdhci-msm.c >>> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { >>> */ >>> {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, >>> {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, >>> + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, >> >>Supporting device trees which are invalid under 6.0 schema? It's not a bug fix, >>it's a feature. > > Does this not enable hardware to work properly? We take quirks/device > enablement into stable tree as well. It does, given that there are no device tree dependency issues. Thanks for the clarification. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-14 0:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221009234932.1230196-1-sashal@kernel.org>
2022-10-09 23:49 ` [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 Sasha Levin
2022-10-10 23:43 ` Richard Acayan
2022-10-13 17:59 ` Sasha Levin
2022-10-14 0:37 ` Richard Acayan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).