[PATCH v2 01/14] phy: qcom-qmp: drop regulator error message

linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 01/14] phy: qcom-qmp: drop regulator error message
Date: Wed, 12 Oct 2022 10:12:28 +0200	[thread overview]
Message-ID: <20221012081241.18273-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221012081241.18273-1-johan+linaro@kernel.org>

Regulator core already logs an error message in case requesting a
regulator fails so drop the mostly redundant error message from probe.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c        | 3 +--
 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 3 +--
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c         | 3 +--
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c          | 3 +--
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c          | 3 +--
 5 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 7b434e2ee640..998c8f80ccd8 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2816,8 +2816,7 @@ static int qmp_combo_probe(struct platform_device *pdev)
 
 	ret = qmp_combo_vreg_init(dev, cfg);
 	if (ret)
-		return dev_err_probe(dev, ret,
-				     "failed to get regulator supplies\n");
+		return ret;
 
 	num = of_get_available_child_count(dev->of_node);
 	/* do we have a rogue child node ? */
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
index 5fdd85a1dc3e..45c0e2958bf6 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
@@ -869,8 +869,7 @@ static int qmp_pcie_msm8996_probe(struct platform_device *pdev)
 
 	ret = qmp_pcie_msm8996_vreg_init(dev, cfg);
 	if (ret)
-		return dev_err_probe(dev, ret,
-				     "failed to get regulator supplies\n");
+		return ret;
 
 	num = of_get_available_child_count(dev->of_node);
 	/* do we have a rogue child node ? */
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index 30838ae8f027..dc7f8ba413b9 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -2445,8 +2445,7 @@ static int qmp_pcie_probe(struct platform_device *pdev)
 
 	ret = qmp_pcie_vreg_init(dev, cfg);
 	if (ret)
-		return dev_err_probe(dev, ret,
-				     "failed to get regulator supplies\n");
+		return ret;
 
 	num = of_get_available_child_count(dev->of_node);
 	/* do we have a rogue child node ? */
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index e28c45ab74ea..566365fbfe1a 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -1210,8 +1210,7 @@ static int qmp_ufs_probe(struct platform_device *pdev)
 
 	ret = qmp_ufs_vreg_init(dev, cfg);
 	if (ret)
-		return dev_err_probe(dev, ret,
-				     "failed to get regulator supplies\n");
+		return ret;
 
 	num = of_get_available_child_count(dev->of_node);
 	/* do we have a rogue child node ? */
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index b0b13fb6cb59..a0b97fd5d0a5 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -2746,8 +2746,7 @@ static int qmp_usb_probe(struct platform_device *pdev)
 
 	ret = qmp_usb_vreg_init(dev, cfg);
 	if (ret)
-		return dev_err_probe(dev, ret,
-				     "failed to get regulator supplies\n");
+		return ret;
 
 	num = of_get_available_child_count(dev->of_node);
 	/* do we have a rogue child node ? */
-- 
2.35.1

next prev parent reply	other threads:[~2022-10-12  8:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  8:12 [PATCH v2 00/14] phy: qcom-qmp: further prep cleanups Johan Hovold
2022-10-12  8:12 ` Johan Hovold [this message]
2022-10-12  8:12 ` [PATCH v2 02/14] phy: qcom-qmp: drop superfluous comments Johan Hovold
2022-10-12  8:12 ` [PATCH v2 03/14] phy: qcom-qmp-combo: drop unused in-layout configuration Johan Hovold
2022-10-12  8:12 ` [PATCH v2 04/14] phy: qcom-qmp-pcie: drop redundant ipq8074 power on Johan Hovold
2022-10-12  8:12 ` [PATCH v2 05/14] phy: qcom-qmp-pcie-msm8996: drop unused in-layout configuration Johan Hovold
2022-10-12  8:12 ` [PATCH v2 06/14] phy: qcom-qmp-ufs: " Johan Hovold
2022-10-12  8:12 ` [PATCH v2 07/14] phy: qcom-qmp-usb: " Johan Hovold
2022-10-12 20:39   ` Dmitry Baryshkov
2022-10-12  8:12 ` [PATCH v2 08/14] phy: qcom-qmp-pcie: drop power-down delay config Johan Hovold
2022-10-12  8:12 ` [PATCH v2 09/14] phy: qcom-qmp-pcie: replace power-down delay Johan Hovold
2022-10-12 20:40   ` Dmitry Baryshkov
2022-10-12  8:12 ` [PATCH v2 10/14] phy: qcom-qmp-pcie-msm8996: drop power-down delay config Johan Hovold
2022-10-12  8:12 ` [PATCH v2 11/14] phy: qcom-qmp-combo: drop sc8280xp power-down delay Johan Hovold
2022-10-12 20:41   ` Dmitry Baryshkov
2022-10-12  8:12 ` [PATCH v2 12/14] phy: qcom-qmp-combo: drop power-down delay config Johan Hovold
2022-10-12  8:12 ` [PATCH v2 13/14] phy: qcom-qmp-usb: drop sc8280xp power-down delay Johan Hovold
2022-10-12 20:41   ` Dmitry Baryshkov
2022-10-12  8:12 ` [PATCH v2 14/14] phy: qcom-qmp-usb: drop power-down delay config Johan Hovold
2022-10-12 12:35 ` [PATCH v2 00/14] phy: qcom-qmp: further prep cleanups Johan Hovold
2022-10-28 12:12 ` Vinod Koul

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:7b434e2ee64 dfblob:998c8f80ccd dfblob:5fdd85a1dc3
dfblob:45c0e2958bf dfblob:30838ae8f02 dfblob:dc7f8ba413b
dfblob:e28c45ab74e dfblob:566365fbfe1 dfblob:b0b13fb6cb5
dfblob:a0b97fd5d0a )
 OR (
bs:"[PATCH v2 01/14] phy: qcom-qmp: drop regulator error message" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221012081241.18273-2-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@ti.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).