From: Richard Acayan <mailingradian@gmail.com>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
agross@kernel.org, andersson@kernel.org, adrian.hunter@intel.com,
linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670
Date: Thu, 13 Oct 2022 20:37:44 -0400 [thread overview]
Message-ID: <20221014003744.6437-1-mailingradian@gmail.com> (raw)
In-Reply-To: <Y0hSFl3Vqo1LCpNg@sashalap>
> On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote:
>>> From: Richard Acayan <mailingradian@gmail.com>
>>>
>>> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ]
>>>
>>> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to
>>> restore the dll config). Add a compatible string check to detect the need
>>> for this.
>>>
>>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>>> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com
>>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>>> ---
>>> drivers/mmc/host/sdhci-msm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>>> index dc2991422a87..3a091a387ecb 100644
>>> --- a/drivers/mmc/host/sdhci-msm.c
>>> +++ b/drivers/mmc/host/sdhci-msm.c
>>> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
>>> */
>>> {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var},
>>> {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var},
>>> + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var},
>>
>>Supporting device trees which are invalid under 6.0 schema? It's not a bug fix,
>>it's a feature.
>
> Does this not enable hardware to work properly? We take quirks/device
> enablement into stable tree as well.
It does, given that there are no device tree dependency issues. Thanks for the
clarification.
prev parent reply other threads:[~2022-10-14 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221009234932.1230196-1-sashal@kernel.org>
2022-10-09 23:49 ` [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 Sasha Levin
2022-10-10 23:43 ` Richard Acayan
2022-10-13 17:59 ` Sasha Levin
2022-10-14 0:37 ` Richard Acayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014003744.6437-1-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).