From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A76C433FE for ; Fri, 14 Oct 2022 06:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbiJNGKW (ORCPT ); Fri, 14 Oct 2022 02:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbiJNGKU (ORCPT ); Fri, 14 Oct 2022 02:10:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E544887F81; Thu, 13 Oct 2022 23:10:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 604E5B81FBE; Fri, 14 Oct 2022 06:10:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F0AEC433C1; Fri, 14 Oct 2022 06:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665727816; bh=CiefB9Bs7UdCwH3zk05eBuTxLD49fBRg6WyB1mAS/Yw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AGxdNMhZm8rMatlboAOXRBQ+27845QkClFJqntmo7HHGRn0yQ3iYkMcipgXo7ipmK X3O0Vo98Z9VayqUJxZoYmZwSynh758eJ5e/Nz2+UJ+SQhjGd8ebemUQFPx+zQzNtSU pBzRkSwofMsH55tzuHU67zS7hVaXD/yHlFA51l5UkYOM7XPl2ufPPHj5yt/5gpxLym uwcxppPsMCP/7ZhVDPtemToQdqw21Z7r16gjoaoHfRkQsYPCkRT2mQP2aMw8hQrDz0 CWTGD6ZPS/cVQCwAbMUBIDTCjmPa/AIHwxvGCstYf+Z4QIdR1opYRPoC8/RbqEW9U/ g+c5SYxc1sXAg== Date: Fri, 14 Oct 2022 11:40:00 +0530 From: Manivannan Sadhasivam To: Vidya Sagar Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, mani@kernel.org, Sergey.Semin@baikalelectronics.ru, dmitry.baryshkov@linaro.org, linmq006@gmail.com, ffclaire1224@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V5 0/3] PCI: designware-ep: Fix DBI access before core init Message-ID: <20221014061000.GA316241@thinkpad> References: <20221013175712.7539-1-vidyas@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221013175712.7539-1-vidyas@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Vidya, On Thu, Oct 13, 2022 at 11:27:09PM +0530, Vidya Sagar wrote: > This series attempts to fix the issue with core register (Ex:- DBI) accesses > causing system hang issues in platforms where there is a dependency on the > availability of PCIe Reference clock from the host for their core > initialization. > This series is verified on Tegra194 & Tegra234 platforms. > > Manivannan, could you please verify on qcom platforms? > Currently I'm on paternity leave this week and next. Will test/review the latest version once I'm back. Thanks, Mani > V5: > * Addressed review comments from Bjorn > * Changed dw_pcie_ep_init_complete() to dw_pcie_ep_init_late() > * Skipped memory allocation if done already. This is to avoid freeing and then > allocating again during PERST# toggles from the host. > > V4: > * Addressed review comments from Bjorn and Manivannan > * Added .ep_init_late() ops > * Added patches to refactor code in qcom and tegra platforms > > Vidya Sagar (3): > PCI: designware-ep: Fix DBI access before core init > PCI: qcom-ep: Refactor EP initialization completion > PCI: tegra194: Refactor EP initialization completion > > .../pci/controller/dwc/pcie-designware-ep.c | 125 +++++++++++------- > drivers/pci/controller/dwc/pcie-designware.h | 10 +- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 27 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 4 +- > 4 files changed, 97 insertions(+), 69 deletions(-) > > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்