[PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

[PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

[Caleb Connolly]

This contains patches 6 through 10 of the series adding a driver
for the RRADC
https://lore.kernel.org/linux-arm-msm/20220429220904.137297-1-caleb.connolly@linaro.org/

The driver and DT bindings have been in mainline for a while.

This introduces a new dtbs_check warning which is fixed in
https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
and depends on Luca's series:
https://lore.kernel.org/linux-arm-msm/20220925211744.133947-2-luca@z3ntu.xyz/

  -Caleb

Caleb Connolly (4):
  arm64: dts: qcom: pmi8998: add rradc node
  arm64: dts: qcom: sdm845-oneplus: enable rradc
  arm64: dts: qcom: sdm845-db845c: enable rradc
  arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc

Jami Kettunen (1):
  arm64: dts: qcom: msm8998-oneplus-common: enable RRADC

 arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ++++
 arch/arm64/boot/dts/qcom/pmi8998.dtsi                | 8 ++++++++
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts           | 4 ++++
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi  | 4 ++++
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 ++++
 5 files changed, 24 insertions(+)

-- 
2.38.0

[PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node

[Caleb Connolly]

Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index 6d3d212560c1..5a479259c041 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		pmi8998_rradc: adc@4500 {
+			compatible = "qcom,pmi8998-rradc";
+			reg = <0x4500>;
+			#io-channel-cells = <1>;
+
+			status = "disabled";
+		};
 	};
 
 	pmi8998_lsid1: pmic@3 {
-- 
2.38.0

Re: [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node

[Krzysztof Kozlowski]

On 16/10/2022 14:03, Caleb Connolly wrote:
> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 6d3d212560c1..5a479259c041 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> +
> +		pmi8998_rradc: adc@4500 {
> +			compatible = "qcom,pmi8998-rradc";
> +			reg = <0x4500>;
> +			#io-channel-cells = <1>;
> +
> +			status = "disabled";

Why disabling it? It does not need any external/board resources, so
maybe it should be just like other adcs - enabled by default? What does
it measure? What is its input?

Best regards,
Krzysztof

Re: [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node

[Caleb Connolly]

On 17/10/2022 02:10, Krzysztof Kozlowski wrote:
> On 16/10/2022 14:03, Caleb Connolly wrote:
>> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
>> index 6d3d212560c1..5a479259c041 100644
>> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
>> @@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
>>   			interrupt-controller;
>>   			#interrupt-cells = <2>;
>>   		};
>> +
>> +		pmi8998_rradc: adc@4500 {
>> +			compatible = "qcom,pmi8998-rradc";
>> +			reg = <0x4500>;
>> +			#io-channel-cells = <1>;
>> +
>> +			status = "disabled";
> 
> Why disabling it? It does not need any external/board resources, so
> maybe it should be just like other adcs - enabled by default? What does
> it measure? What is its input?

The RRADC mostly reports values which only make sense on mobile devices, battery 
ID and temperature, USB and DC input voltage/current as well as a (duplicate?) 
die temperature of the PMIC - I guess closer to the SMB/FG block.

When I last tested the DC input readings didn't work on db845c, as it just 
produces the 4.2v you'd get from a battery.

Enabling it by default should be fine (and would certainly simplify this series :P).
> 
> Best regards,
> Krzysztof
> 

-- 
Kind Regards,
Caleb (they/them)

Re: [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node

[Krzysztof Kozlowski]

On 17/10/2022 11:29, Caleb Connolly wrote:

>>> +		pmi8998_rradc: adc@4500 {
>>> +			compatible = "qcom,pmi8998-rradc";
>>> +			reg = <0x4500>;
>>> +			#io-channel-cells = <1>;
>>> +
>>> +			status = "disabled";
>>
>> Why disabling it? It does not need any external/board resources, so
>> maybe it should be just like other adcs - enabled by default? What does
>> it measure? What is its input?
> 
> The RRADC mostly reports values which only make sense on mobile devices, battery 
> ID and temperature, USB and DC input voltage/current as well as a (duplicate?) 
> die temperature of the PMIC - I guess closer to the SMB/FG block.
> 
> When I last tested the DC input readings didn't work on db845c, as it just 
> produces the 4.2v you'd get from a battery.

If it is connected to some line - e.g. to the battery - then it is
operational and there is no reason to disable it.


Best regards,
Krzysztof

[PATCH 2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc

[Caleb Connolly]

Enable the RRADC for the OnePlus 6.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 392461c29e76..be9db844e5a1 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -461,6 +461,10 @@ pinconf {
 	};
 };
 
+&pmi8998_rradc {
+	status = "okay";
+};
+
 &qupv3_id_1 {
 	status = "okay";
 };
-- 
2.38.0

[PATCH 3/5] arm64: dts: qcom: sdm845-db845c: enable rradc

[Caleb Connolly]

Enable the Round Robin ADC for the db845c.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index c6e2c571b452..e0ae43ceada5 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -649,6 +649,10 @@ led@5 {
 	};
 };
 
+&pmi8998_rradc {
+	status = "okay";
+};
+
 /* QUAT I2S Uses 4 I2S SD Lines for audio on LT9611 HDMI Bridge */
 &q6afedai {
 	qi2s@22 {
-- 
2.38.0

[PATCH 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc

[Caleb Connolly]

Enable the PMI8998 RRADC.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index 82c27f90d300..6228c1899e3a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -336,6 +336,10 @@ resin {
 	};
 };
 
+&pmi8998_rradc {
+	status = "okay";
+};
+
 /* QUAT I2S Uses 1 I2S SD Line for audio on TAS2559/60 amplifiers */
 &q6afedai {
 	qi2s@22 {
-- 
2.38.0

[PATCH 5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC

[Caleb Connolly]

From: Jami Kettunen <jami.kettunen@somainline.org>

Enable the Round Robin ADC for the OnePlus 5/5T.

Signed-off-by: Jami Kettunen <jami.kettunen@somainline.org>
---
 arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
index 62bda23791bb..5650bf5e604e 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
@@ -279,6 +279,10 @@ vol_keys_default: vol-keys-state {
 	};
 };
 
+&pmi8998_rradc {
+	status = "okay";
+};
+
 &qusb2phy {
 	status = "okay";
 
-- 
2.38.0

Re: [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

[Bjorn Andersson]

On Sun, 16 Oct 2022 19:03:24 +0100, Caleb Connolly wrote:
> This contains patches 6 through 10 of the series adding a driver
> for the RRADC
> https://lore.kernel.org/linux-arm-msm/20220429220904.137297-1-caleb.connolly@linaro.org/
> 
> The driver and DT bindings have been in mainline for a while.
> 
> This introduces a new dtbs_check warning which is fixed in
> https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
> and depends on Luca's series:
> https://lore.kernel.org/linux-arm-msm/20220925211744.133947-2-luca@z3ntu.xyz/
> 
> [...]

Applied, thanks!

[1/5] arm64: dts: qcom: pmi8998: add rradc node
      commit: 1cb78978d34e1b65bbb912d8265eb95713ae7a45
[2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc
      commit: 868985181a69df53321035d96aa668d90f6cd5cb
[3/5] arm64: dts: qcom: sdm845-db845c: enable rradc
      commit: e779eb99859cc26d051f6fc723d2bd2d5990a812
[4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc
      commit: 53c54069d9ffd556b52893077324e628655cd591
[5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC
      commit: aac16a9d247e5496361bfe20d651f2c1333eb5dc

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

[Caleb Connolly]

On 07/11/2022 03:11, Bjorn Andersson wrote:
> On Sun, 16 Oct 2022 19:03:24 +0100, Caleb Connolly wrote:
>> This contains patches 6 through 10 of the series adding a driver
>> for the RRADC
>> https://lore.kernel.org/linux-arm-msm/20220429220904.137297-1-caleb.connolly@linaro.org/
>>
>> The driver and DT bindings have been in mainline for a while.
>>
>> This introduces a new dtbs_check warning which is fixed in
>> https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
>> and depends on Luca's series:
>> https://lore.kernel.org/linux-arm-msm/20220925211744.133947-2-luca@z3ntu.xyz/
>>
>> [...]
> 
> Applied, thanks!

Hi Bjorn,

Apologies, I should have left a reply about re-spinning this; it's 
been dropped to a single patch as Krzysztof suggested in [1] and is 
currently pending a v4 (v3 can be found at [2]).

The changes aren't major, actually just enabling it by default rather 
than per-device. If it would need to be reverted I could instead send 
a followup to do this as well as add the missing dt bindings.

[1]: 
https://lore.kernel.org/linux-arm-msm/5929051d-d2be-5b51-0cf9-294affa51df2@linaro.org/
[2]: 
https://lore.kernel.org/linux-arm-msm/20221017190902.2282899-1-caleb.connolly@linaro.org/

> 
> [1/5] arm64: dts: qcom: pmi8998: add rradc node
>        commit: 1cb78978d34e1b65bbb912d8265eb95713ae7a45
> [2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc
>        commit: 868985181a69df53321035d96aa668d90f6cd5cb
> [3/5] arm64: dts: qcom: sdm845-db845c: enable rradc
>        commit: e779eb99859cc26d051f6fc723d2bd2d5990a812
> [4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc
>        commit: 53c54069d9ffd556b52893077324e628655cd591
> [5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC
>        commit: aac16a9d247e5496361bfe20d651f2c1333eb5dc
> 
> Best regards,

-- 
Kind Regards,
Caleb (they/them)