From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v3 02/11] phy: qcom-qmp-combo: drop unused UFS reset
Date: Mon, 17 Oct 2022 08:50:04 +0200 [thread overview]
Message-ID: <20221017065013.19647-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221017065013.19647-1-johan+linaro@kernel.org>
Drop the unused UFS reset code which isn't used since the QMP driver
split.
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 8a2a35c0855b..c21512b9ab52 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -944,7 +944,6 @@ struct qmp_phy_dp_clks {
* @phys: array of per-lane phy descriptors
* @phy_mutex: mutex lock for PHY common block initialization
* @init_count: phy common block initialization count
- * @ufs_reset: optional UFS PHY reset handle
*/
struct qcom_qmp {
struct device *dev;
@@ -958,8 +957,6 @@ struct qcom_qmp {
struct mutex phy_mutex;
int init_count;
-
- struct reset_control *ufs_reset;
};
static void qcom_qmp_v3_phy_dp_aux_init(struct qmp_phy *qphy);
@@ -2027,8 +2024,6 @@ static int qmp_combo_com_exit(struct qmp_phy *qphy)
return 0;
}
- reset_control_assert(qmp->ufs_reset);
-
reset_control_bulk_assert(cfg->num_resets, qmp->resets);
clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks);
@@ -2103,10 +2098,6 @@ static int qmp_combo_power_on(struct phy *phy)
else
qmp_combo_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
- ret = reset_control_deassert(qmp->ufs_reset);
- if (ret)
- goto err_disable_pipe_clk;
-
if (cfg->has_pwrdn_delay)
usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max);
--
2.37.3
next prev parent reply other threads:[~2022-10-17 6:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 6:50 [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Johan Hovold
2022-10-17 6:50 ` [PATCH v3 01/11] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-10-17 6:50 ` Johan Hovold [this message]
2022-10-17 6:50 ` [PATCH v3 03/11] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-10-17 6:50 ` [PATCH v3 04/11] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-10-17 6:50 ` [PATCH v3 05/11] phy: qcom-qmp-pcie: move power-down update Johan Hovold
2022-10-17 6:50 ` [PATCH v3 06/11] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold
2022-10-17 6:50 ` [PATCH v3 07/11] phy: qcom-qmp-combo: " Johan Hovold
2022-10-17 6:50 ` [PATCH v3 08/11] phy: qcom-qmp-ufs: " Johan Hovold
2022-10-17 6:50 ` [PATCH v3 09/11] phy: qcom-qmp-usb: " Johan Hovold
2022-10-17 6:50 ` [PATCH v3 10/11] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-10-17 6:50 ` [PATCH v3 11/11] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-10-17 8:15 ` [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017065013.19647-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).