linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v3 06/11] phy: qcom-qmp-pcie-msm8996: clean up power-down handling
Date: Mon, 17 Oct 2022 08:50:08 +0200	[thread overview]
Message-ID: <20221017065013.19647-7-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221017065013.19647-1-johan+linaro@kernel.org>

This driver uses v2 registers only so drop the unnecessary
POWER_DOWN_CONTROL override.

Note that this register is already hard-coded when powering on the PHY.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
index 707ec81c7a2a..5fdd85a1dc3e 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
@@ -91,7 +91,6 @@ enum qphy_reg_layout {
 	QPHY_SW_RESET,
 	QPHY_START_CTRL,
 	QPHY_PCS_STATUS,
-	QPHY_PCS_POWER_DOWN_CONTROL,
 	/* Keep last to ensure regs_layout arrays are properly initialized */
 	QPHY_LAYOUT_SIZE
 };
@@ -591,13 +590,8 @@ static int qmp_pcie_msm8996_power_off(struct phy *phy)
 	qphy_clrbits(qphy->pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl);
 
 	/* Put PHY into POWER DOWN state: active low */
-	if (cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL]) {
-		qphy_clrbits(qphy->pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
-			     cfg->pwrdn_ctrl);
-	} else {
-		qphy_clrbits(qphy->pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL,
-				cfg->pwrdn_ctrl);
-	}
+	qphy_clrbits(qphy->pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL,
+			cfg->pwrdn_ctrl);
 
 	return 0;
 }
-- 
2.37.3


  parent reply	other threads:[~2022-10-17  6:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  6:50 [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Johan Hovold
2022-10-17  6:50 ` [PATCH v3 01/11] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-10-17  6:50 ` [PATCH v3 02/11] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-10-17  6:50 ` [PATCH v3 03/11] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-10-17  6:50 ` [PATCH v3 04/11] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-10-17  6:50 ` [PATCH v3 05/11] phy: qcom-qmp-pcie: move power-down update Johan Hovold
2022-10-17  6:50 ` Johan Hovold [this message]
2022-10-17  6:50 ` [PATCH v3 07/11] phy: qcom-qmp-combo: clean up power-down handling Johan Hovold
2022-10-17  6:50 ` [PATCH v3 08/11] phy: qcom-qmp-ufs: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 09/11] phy: qcom-qmp-usb: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 10/11] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-10-17  6:50 ` [PATCH v3 11/11] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-10-17  8:15 ` [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017065013.19647-7-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).