linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 07/15] phy: qcom-qmp-pcie: clean up PHY lane init
Date: Mon, 17 Oct 2022 16:53:20 +0200	[thread overview]
Message-ID: <20221017145328.22090-8-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221017145328.22090-1-johan+linaro@kernel.org>

Clean up the PHY lane initialisation somewhat by adding further
temporary variables and programming both tx and rx for the second lane
after the first lane.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index bd946438e3c3..dd7e72424fc0 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1835,18 +1835,19 @@ static void qmp_pcie_lanes_init(struct qmp_pcie *qmp, const struct qmp_phy_cfg_t
 	const struct qmp_phy_cfg *cfg = qmp->cfg;
 	void __iomem *tx = qmp->tx;
 	void __iomem *rx = qmp->rx;
+	void __iomem *tx2 = qmp->tx2;
+	void __iomem *rx2 = qmp->rx2;
 
 	if (!tables)
 		return;
 
 	qmp_pcie_configure_lane(tx, tables->tx, tables->tx_num, 1);
-
-	if (cfg->lanes >= 2)
-		qmp_pcie_configure_lane(qmp->tx2, tables->tx, tables->tx_num, 2);
-
 	qmp_pcie_configure_lane(rx, tables->rx, tables->rx_num, 1);
-	if (cfg->lanes >= 2)
-		qmp_pcie_configure_lane(qmp->rx2, tables->rx, tables->rx_num, 2);
+
+	if (cfg->lanes >= 2) {
+		qmp_pcie_configure_lane(tx2, tables->tx, tables->tx_num, 2);
+		qmp_pcie_configure_lane(rx2, tables->rx, tables->rx_num, 2);
+	}
 }
 
 static void qmp_pcie_pcs_init(struct qmp_pcie *qmp, const struct qmp_phy_cfg_tables *tables)
-- 
2.37.3


  parent reply	other threads:[~2022-10-17 15:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 14:53 [PATCH 00/15] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-17 14:53 ` [PATCH 01/15] phy: qcom-qmp-pcie: sort device-id table Johan Hovold
2022-10-17 14:53 ` [PATCH 02/15] phy: qcom-qmp-pcie: move " Johan Hovold
2022-10-17 14:53 ` [PATCH 03/15] phy: qcom-qmp-pcie: merge driver data Johan Hovold
2022-10-17 14:53 ` [PATCH 04/15] phy: qcom-qmp-pcie: clean up device-tree parsing Johan Hovold
2022-10-17 14:53 ` [PATCH 05/15] phy: qcom-qmp-pcie: clean up probe initialisation Johan Hovold
2022-10-17 14:53 ` [PATCH 06/15] phy: qcom-qmp-pcie: rename PHY ops structure Johan Hovold
2022-10-17 14:53 ` Johan Hovold [this message]
2022-10-17 14:53 ` [PATCH 08/15] phy: qcom-qmp-pcie: add register init helper Johan Hovold
2022-10-17 14:53 ` [PATCH 09/15] dt-bindings: phy: qcom,qmp-pcie: mark current bindings as legacy Johan Hovold
2022-10-17 17:15   ` Krzysztof Kozlowski
2022-10-18  7:06     ` Johan Hovold
2022-10-18 15:27       ` Krzysztof Kozlowski
2022-10-18 15:49         ` Johan Hovold
2022-10-18  9:52   ` Dmitry Baryshkov
2022-10-18 10:21     ` Johan Hovold
2022-10-18 11:37       ` Dmitry Baryshkov
2022-10-18 12:44         ` Johan Hovold
2022-10-18 15:32         ` Krzysztof Kozlowski
2022-10-18 16:04           ` Johan Hovold
2022-10-18 16:44             ` Krzysztof Kozlowski
2022-10-19  9:33               ` Johan Hovold
2022-10-17 14:53 ` [PATCH 10/15] dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings Johan Hovold
2022-10-17 17:20   ` Krzysztof Kozlowski
2022-10-18  9:40     ` Johan Hovold
2022-10-18 15:22       ` Krzysztof Kozlowski
2022-10-18 15:47         ` Johan Hovold
2022-10-17 14:53 ` [PATCH 11/15] phy: qcom-qmp-pcie: restructure PHY creation Johan Hovold
2022-10-17 14:53 ` [PATCH 12/15] phy: qcom-qmp-pcie: fix initialisation reset Johan Hovold
2022-10-17 14:53 ` [PATCH 13/15] phy: qcom-qmp-pcie: add support for pipediv2 clock Johan Hovold
2022-10-18 13:05   ` Dmitry Baryshkov
2022-10-18 14:53     ` Johan Hovold
2022-10-17 14:53 ` [PATCH 14/15] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-17 14:53 ` [PATCH 15/15] phy: qcom-qmp-pcie: add support for sc8280xp 4-lane PHYs Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017145328.22090-8-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).