From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, jassisinghbrar@gmail.com,
manivannan.sadhasivam@linaro.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org,
Gaurav Kohli <gkohli@codeaurora.org>
Subject: Re: [PATCH 2/2] mailbox: Add support for QTI CPUCP mailbox controller
Date: Thu, 3 Nov 2022 11:02:39 +0000 [thread overview]
Message-ID: <20221103110239.lkb7a5a4fpk2ggrs@bogus> (raw)
In-Reply-To: <1663135386-26270-3-git-send-email-quic_sibis@quicinc.com>
On Wed, Sep 14, 2022 at 11:33:06AM +0530, Sibi Sankar wrote:
> Add support for CPUSS Control Processor (CPUCP) mailbox controller,
> this driver enables communication between AP and CPUCP by acting as
> a doorbell between them.
>
> Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
> [sibis: moved to mailbox and misc. cleanups]
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
[...]
> +
> + ret = devm_request_irq(&pdev->dev, cpucp->irq, qcom_cpucp_mbox_irq_fn,
> + IRQF_TRIGGER_HIGH | IRQF_NO_SUSPEND, "qcom_cpucp_mbox", cpucp);
1. Do you plan to use this mailbox during noirq phase of system suspend ?
If not why do you have IRQF_NO_SUSPEND ? If yes, how will it be used ?
2. Why are you setting IRQF_TRIGGER_HIGH here ? Won't platform_get_irq()
take care of that ? Otherwise how would you use this driver on the
platform that need say IRQF_TRIGGER_LOW ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-11-03 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 6:03 [PATCH 0/2] Add support for CPUCP mailbox controller Sibi Sankar
2022-09-14 6:03 ` [PATCH 1/2] dt-bindings: mailbox: Add dt binding for QTI " Sibi Sankar
2022-09-14 11:08 ` Rob Herring
2022-09-15 1:39 ` Sibi Sankar
2022-09-14 6:03 ` [PATCH 2/2] mailbox: Add support " Sibi Sankar
2022-09-14 17:38 ` Trilok Soni
2022-09-15 1:33 ` Sibi Sankar
2022-09-14 17:52 ` Bjorn Andersson
2022-11-03 11:02 ` Sudeep Holla [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-13 14:04 [PATCH 0/2] Add support for " Sibi Sankar
2022-12-13 14:04 ` [PATCH 2/2] mailbox: Add support for QTI " Sibi Sankar
2022-12-13 14:09 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103110239.lkb7a5a4fpk2ggrs@bogus \
--to=sudeep.holla@arm.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gkohli@codeaurora.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox