linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
@ 2022-11-07  9:29 Robert Marko
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Robert Marko @ 2022-11-07  9:29 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: Robert Marko

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
index db4b87944cdf..262b937e0bc6 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
@@ -22,7 +22,7 @@ memory {
 };
 
 &blsp1_spi1 {
-	status = "ok";
+	status = "okay";
 
 	flash@0 {
 		#address-cells = <1>;
@@ -34,33 +34,33 @@ flash@0 {
 };
 
 &blsp1_uart5 {
-	status = "ok";
+	status = "okay";
 };
 
 &pcie0 {
-	status = "ok";
+	status = "okay";
 	perst-gpios = <&tlmm 58 0x1>;
 };
 
 &pcie1 {
-	status = "ok";
+	status = "okay";
 	perst-gpios = <&tlmm 61 0x1>;
 };
 
 &pcie_phy0 {
-	status = "ok";
+	status = "okay";
 };
 
 &pcie_phy1 {
-	status = "ok";
+	status = "okay";
 };
 
 &qpic_bam {
-	status = "ok";
+	status = "okay";
 };
 
 &qpic_nand {
-	status = "ok";
+	status = "okay";
 
 	nand@0 {
 		reg = <0>;
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
  2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
@ 2022-11-07  9:29 ` Robert Marko
  2022-11-07  9:58   ` Konrad Dybcio
                     ` (2 more replies)
  2022-11-07  9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
                   ` (3 subsequent siblings)
  4 siblings, 3 replies; 11+ messages in thread
From: Robert Marko @ 2022-11-07  9:29 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
harcoding the cell value.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
index 262b937e0bc6..651a231554e0 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
@@ -5,6 +5,7 @@
 /dts-v1/;
 
 #include "ipq8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	aliases {
@@ -39,12 +40,12 @@ &blsp1_uart5 {
 
 &pcie0 {
 	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
 };
 
 &pcie1 {
 	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
 };
 
 &pcie_phy0 {
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
  2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
@ 2022-11-07  9:29 ` Robert Marko
  2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07 10:31   ` Krzysztof Kozlowski
  2022-11-07  9:53 ` [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Konrad Dybcio
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 11+ messages in thread
From: Robert Marko @ 2022-11-07  9:29 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
harcoding the cell value.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
index b60b2d4c2ea5..c3f3f78271e9 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
@@ -4,6 +4,7 @@
  */
 #include "ipq8074.dtsi"
 #include "pmp8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Qualcomm Technologies, Inc. IPQ8074-HK01";
@@ -52,12 +53,12 @@ &blsp1_uart5 {
 
 &pcie0 {
 	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
 };
 
 &pcie1 {
 	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
 };
 
 &pcie_phy0 {
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
  2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
  2022-11-07  9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
@ 2022-11-07  9:53 ` Konrad Dybcio
  2022-11-07 10:31 ` Krzysztof Kozlowski
  2022-11-08  1:27 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-11-07  9:53 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel



On 07/11/2022 10:29, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index db4b87944cdf..262b937e0bc6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -22,7 +22,7 @@ memory {
>   };
>   
>   &blsp1_spi1 {
> -	status = "ok";
> +	status = "okay";
>   
>   	flash@0 {
>   		#address-cells = <1>;
> @@ -34,33 +34,33 @@ flash@0 {
>   };
>   
>   &blsp1_uart5 {
> -	status = "ok";
> +	status = "okay";
>   };
>   
>   &pcie0 {
> -	status = "ok";
> +	status = "okay";
>   	perst-gpios = <&tlmm 58 0x1>;
>   };
>   
>   &pcie1 {
> -	status = "ok";
> +	status = "okay";
>   	perst-gpios = <&tlmm 61 0x1>;
>   };
>   
>   &pcie_phy0 {
> -	status = "ok";
> +	status = "okay";
>   };
>   
>   &pcie_phy1 {
> -	status = "ok";
> +	status = "okay";
>   };
>   
>   &qpic_bam {
> -	status = "ok";
> +	status = "okay";
>   };
>   
>   &qpic_nand {
> -	status = "ok";
> +	status = "okay";
>   
>   	nand@0 {
>   		reg = <0>;

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
@ 2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07 10:31   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-11-07  9:58 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel



On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

KOnrad
>   arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index 262b937e0bc6..651a231554e0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -5,6 +5,7 @@
>   /dts-v1/;
>   
>   #include "ipq8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>   
>   / {
>   	aliases {
> @@ -39,12 +40,12 @@ &blsp1_uart5 {
>   
>   &pcie0 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 58 0x1>;
> +	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie1 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 61 0x1>;
> +	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie_phy0 {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
  2022-11-07  9:58   ` Konrad Dybcio
@ 2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07 10:31   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-11-07  9:58 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel



On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index 262b937e0bc6..651a231554e0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -5,6 +5,7 @@
>   /dts-v1/;
>   
>   #include "ipq8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>   
>   / {
>   	aliases {
> @@ -39,12 +40,12 @@ &blsp1_uart5 {
>   
>   &pcie0 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 58 0x1>;
> +	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie1 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 61 0x1>;
> +	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie_phy0 {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
  2022-11-07  9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
@ 2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07 10:31   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-11-07  9:58 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel



On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> index b60b2d4c2ea5..c3f3f78271e9 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> @@ -4,6 +4,7 @@
>    */
>   #include "ipq8074.dtsi"
>   #include "pmp8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>   
>   / {
>   	model = "Qualcomm Technologies, Inc. IPQ8074-HK01";
> @@ -52,12 +53,12 @@ &blsp1_uart5 {
>   
>   &pcie0 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 61 0x1>;
> +	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie1 {
>   	status = "okay";
> -	perst-gpios = <&tlmm 58 0x1>;
> +	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
>   };
>   
>   &pcie_phy0 {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
  2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
                   ` (2 preceding siblings ...)
  2022-11-07  9:53 ` [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Konrad Dybcio
@ 2022-11-07 10:31 ` Krzysztof Kozlowski
  2022-11-08  1:27 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-07 10:31 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel

On 07/11/2022 10:29, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
  2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
  2022-11-07  9:58   ` Konrad Dybcio
  2022-11-07  9:58   ` Konrad Dybcio
@ 2022-11-07 10:31   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-07 10:31 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel

On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
  2022-11-07  9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
  2022-11-07  9:58   ` Konrad Dybcio
@ 2022-11-07 10:31   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-07 10:31 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel

On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: (subset) [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
  2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
                   ` (3 preceding siblings ...)
  2022-11-07 10:31 ` Krzysztof Kozlowski
@ 2022-11-08  1:27 ` Bjorn Andersson
  4 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2022-11-08  1:27 UTC (permalink / raw)
  To: robimarko, devicetree, robh+dt, konrad.dybcio,
	krzysztof.kozlowski+dt, agross, linux-kernel, linux-arm-msm

On Mon, 7 Nov 2022 10:29:28 +0100, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
> 
> 

Applied, thanks!

[1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
      commit: 7284a3943909606016128b79fb18dd107bc0fe26
[2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
      commit: 3f49bdaf6f84959bb8fc3ed5add7983907491240
[3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
      commit: 1bc6b7f26bc72c8fd5a49ff000bb76a234e75e11

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-11-08  1:29 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-07  9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
2022-11-07  9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
2022-11-07  9:58   ` Konrad Dybcio
2022-11-07  9:58   ` Konrad Dybcio
2022-11-07 10:31   ` Krzysztof Kozlowski
2022-11-07  9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
2022-11-07  9:58   ` Konrad Dybcio
2022-11-07 10:31   ` Krzysztof Kozlowski
2022-11-07  9:53 ` [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Konrad Dybcio
2022-11-07 10:31 ` Krzysztof Kozlowski
2022-11-08  1:27 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).