From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77501C4332F for ; Wed, 16 Nov 2022 14:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiKPOk0 (ORCPT ); Wed, 16 Nov 2022 09:40:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231467AbiKPOkZ (ORCPT ); Wed, 16 Nov 2022 09:40:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 466782D777; Wed, 16 Nov 2022 06:40:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6F5661E5C; Wed, 16 Nov 2022 14:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15619C433C1; Wed, 16 Nov 2022 14:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668609623; bh=tHH0R7tHVRFkDxhwOWJ+H+4wBMVKPOoCZMJ+PF+E69c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LPW9WLVVcIQ3BZmBDkwW+HZaWMtvDSY/nruFFvGYD+4k/dJGORMD38yUDg4IPqtI1 FiBhKy+xgwJ1KuGsTCIEtlRJVJWa4mB5E32esQ0hQkNOOcvchXtfYnYffyp57cJkLb xUiZwV3mwLakTSh5xdvoguzEhi+LDE5U/r0rleLHMdYbH3MnNvOw4APkE8FxzsxIzk s8PjV5ZdYjYoTt+ewRrfLagHUmQlZ6mR9F2OFiOPvnFJ6AHtJa7KXGwlrGU2+V0Qal n2jblUxx0SGsoJ+BVmhGqrWrNZSCpLvYfQ2vtnejNQQryy0VSMPxzgafjC6HWo6rdG it9RQ60eQvVFw== Date: Wed, 16 Nov 2022 20:10:15 +0530 From: Manivannan Sadhasivam To: Slark Xiao Cc: mani@kernel.org, gregkh@linuxfoundation.org, loic.poulain@linaro.org, dnlplm@gmail.com, yonglin.tan@outlook.com, fabio.porcedda@gmail.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] bus: mhi: host: pci_generic: Add definition for some VIDs Message-ID: <20221116144015.GA4017@thinkpad> References: <20221107112700.773-1-slark_xiao@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221107112700.773-1-slark_xiao@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Nov 07, 2022 at 07:27:00PM +0800, Slark Xiao wrote: > To make code neat and for convenience purpose, add definition for some > VIDs. Adding it locally until these VIDs are used in multiple places. > > Signed-off-by: Slark Xiao Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > v3: Update description > v2: Update description and fix format issue > --- > drivers/bus/mhi/host/pci_generic.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index c4259cb2d289..3a789bb2f631 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -24,6 +24,10 @@ > > #define HEALTH_CHECK_PERIOD (HZ * 2) > > +/* PCI VID definitions */ > +#define PCI_VENDOR_ID_THALES 0x1269 > +#define PCI_VENDOR_ID_QUECTEL 0x1eac > + > /** > * struct mhi_pci_dev_info - MHI PCI device specific information > * @config: MHI controller configuration > @@ -557,11 +561,11 @@ static const struct pci_device_id mhi_pci_id_table[] = { > .driver_data = (kernel_ulong_t) &mhi_telit_fn990_info }, > { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308), > .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info }, > - { PCI_DEVICE(0x1eac, 0x1001), /* EM120R-GL (sdx24) */ > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1001), /* EM120R-GL (sdx24) */ > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info }, > - { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */ > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */ > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info }, > - { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */ > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */ > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info }, > /* T99W175 (sdx55), Both for eSIM and Non-eSIM */ > { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab), > @@ -585,16 +589,16 @@ static const struct pci_device_id mhi_pci_id_table[] = { > { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0d9), > .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info }, > /* MV31-W (Cinterion) */ > - { PCI_DEVICE(0x1269, 0x00b3), > + { PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3), > .driver_data = (kernel_ulong_t) &mhi_mv31_info }, > /* MV31-W (Cinterion), based on new baseline */ > - { PCI_DEVICE(0x1269, 0x00b4), > + { PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b4), > .driver_data = (kernel_ulong_t) &mhi_mv31_info }, > /* MV32-WA (Cinterion) */ > - { PCI_DEVICE(0x1269, 0x00ba), > + { PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00ba), > .driver_data = (kernel_ulong_t) &mhi_mv32_info }, > /* MV32-WB (Cinterion) */ > - { PCI_DEVICE(0x1269, 0x00bb), > + { PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00bb), > .driver_data = (kernel_ulong_t) &mhi_mv32_info }, > { } > }; > -- > 2.17.1 > > -- மணிவண்ணன் சதாசிவம்