From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195D1C47089 for ; Mon, 5 Dec 2022 22:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233418AbiLEWXX (ORCPT ); Mon, 5 Dec 2022 17:23:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233451AbiLEWXT (ORCPT ); Mon, 5 Dec 2022 17:23:19 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EF17B7FD; Mon, 5 Dec 2022 14:23:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C52A1B81262; Mon, 5 Dec 2022 22:23:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A8C2C433C1; Mon, 5 Dec 2022 22:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670278995; bh=r7Zbs6ql/zVmwGxY0A2vvhLYDbx61rLzdNI7bJloNmM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N25sRvjt9ynOVmKtUWr0551Jy3GiEGY9HV0ZbMTMbrQhtsBGGuL+iODpFpZh9eC57 1VK5Lk6yv6A0eaec8NaewtUYlPqqQuIg87EkXNMhgKHy9I9fwBdoEx51CSZGGJbIpk geaYrLTRQTPmafEXuW4dElMoWSHXSqulhMgtI+5ACu5dXmSQqlY3K3DjOnmGSVci0J HI+cIbhqJw+7EqnCAcjjw/HOopBqtWv2ixtqM2TRhzdtOZTrJKQtmPcR0SgFreDZDk Lrhn6rLJqLZSqTA7XxIepXKyRODqo9QYmRUtONBdWqPG9HGX6/YWug4tB6VObC/Qx0 kb5rT6Xk3Sm9g== Date: Mon, 5 Dec 2022 16:23:12 -0600 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Bjorn Andersson , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Konrad Dybcio , Kalyan Thota , Jessica Zhang , Kuogee Hsieh , Johan Hovold , Sankeerth Billakanti , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/13] drm/msm/dp: Implement hpd_notify() Message-ID: <20221205222312.gmg65h35d44zigg4@builder.lan> References: <20221205174433.16847-1-quic_bjorande@quicinc.com> <20221205174433.16847-9-quic_bjorande@quicinc.com> <4E586110-168A-4D47-966F-357DF042AFC7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E586110-168A-4D47-966F-357DF042AFC7@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Dec 06, 2022 at 12:29:13AM +0300, Dmitry Baryshkov wrote: > > > On 5 December 2022 20:44:28 GMT+03:00, Bjorn Andersson wrote: > >From: Bjorn Andersson > > > >The DisplayPort controller's hot-plug mechanism is based on pinmuxing a > >physical signal on a GPIO pin into the controller. This is not always > >possible, either because there aren't dedicated GPIOs available or > >because the hot-plug signal is a virtual notification, in cases such as > >USB Type-C. > > > >For these cases, by implementing the hpd_notify() callback for the > >DisplayPort controller's drm_bridge, a downstream drm_bridge > >(next_bridge) can be used to track and signal the connection status > >changes. > > > >This makes it possible to use downstream drm_bridges such as > >display-connector or any virtual mechanism, as long as they are > >implemented as a drm_bridge. > > > >Signed-off-by: Bjorn Andersson > >[bjorn: Drop connector->fwnode assignment and dev from struct msm_dp] > >Signed-off-by: Bjorn Andersson > > Reviewed-by: Dmitry Baryshkov > > Minor nit: if for the next revision you reorder the patches to have > hpd_enable first, then missing conditions, then this patch, it will > look more logical. You're right, that will look better. I'll do so. Thanks, Bjorn > > >--- > > > >Changes since v3: > >- None > > > > drivers/gpu/drm/msm/dp/dp_display.c | 22 ++++++++++++++++++++++ > > drivers/gpu/drm/msm/dp/dp_drm.c | 1 + > > drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ > > 3 files changed, 25 insertions(+) > > > >diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > >index 666b45c8ab80..17fcf8cd84cd 100644 > >--- a/drivers/gpu/drm/msm/dp/dp_display.c > >+++ b/drivers/gpu/drm/msm/dp/dp_display.c > >@@ -1772,3 +1772,25 @@ void dp_bridge_mode_set(struct drm_bridge *drm_bridge, > > dp_display->dp_mode.h_active_low = > > !!(dp_display->dp_mode.drm_mode.flags & DRM_MODE_FLAG_NHSYNC); > > } > >+ > >+void dp_bridge_hpd_notify(struct drm_bridge *bridge, > >+ enum drm_connector_status status) > >+{ > >+ struct msm_dp_bridge *dp_bridge = to_dp_bridge(bridge); > >+ struct msm_dp *dp_display = dp_bridge->dp_display; > >+ struct dp_display_private *dp = container_of(dp_display, struct dp_display_private, dp_display); > >+ > >+ /* Without next_bridge interrupts are handled by the DP core directly */ > >+ if (!dp_display->next_bridge) > >+ return; > >+ > >+ if (!dp->core_initialized) { > >+ drm_dbg_dp(dp->drm_dev, "not initialized\n"); > >+ return; > >+ } > >+ > >+ if (!dp_display->is_connected && status == connector_status_connected) > >+ dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); > >+ else if (dp_display->is_connected && status == connector_status_disconnected) > >+ dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); > >+} > >diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > >index 6db82f9b03af..3898366ebd5e 100644 > >--- a/drivers/gpu/drm/msm/dp/dp_drm.c > >+++ b/drivers/gpu/drm/msm/dp/dp_drm.c > >@@ -102,6 +102,7 @@ static const struct drm_bridge_funcs dp_bridge_ops = { > > .get_modes = dp_bridge_get_modes, > > .detect = dp_bridge_detect, > > .atomic_check = dp_bridge_atomic_check, > >+ .hpd_notify = dp_bridge_hpd_notify, > > }; > > > > struct drm_bridge *dp_bridge_init(struct msm_dp *dp_display, struct drm_device *dev, > >diff --git a/drivers/gpu/drm/msm/dp/dp_drm.h b/drivers/gpu/drm/msm/dp/dp_drm.h > >index 82035dbb0578..79e6b2cf2d25 100644 > >--- a/drivers/gpu/drm/msm/dp/dp_drm.h > >+++ b/drivers/gpu/drm/msm/dp/dp_drm.h > >@@ -32,5 +32,7 @@ enum drm_mode_status dp_bridge_mode_valid(struct drm_bridge *bridge, > > void dp_bridge_mode_set(struct drm_bridge *drm_bridge, > > const struct drm_display_mode *mode, > > const struct drm_display_mode *adjusted_mode); > >+void dp_bridge_hpd_notify(struct drm_bridge *bridge, > >+ enum drm_connector_status status); > > > > #endif /* _DP_DRM_H_ */ > > -- > With best wishes > Dmitry