Re: [PATCH 2/3] arm64: dts: qcom: sm8150-kumano: Add NXP PN553 NFC

[Marijn Suijten <marijn.suijten@somainline.org>]

On 2022-12-10 15:25:24, Konrad Dybcio wrote:
> Add a node for NXP PN553 NFC (or PN557, unclear data), using the
> nxp-nci driver.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Tested-by: Marijn Suijten <marijn.suijten@somainline.org> # On Xperia 1 and Xperia 5

Unfortunately I can only test this with neard-tools' nfctool, which
reports a tag (from another phone) has been detected but does not allow
me to show its contents (I may have simply not figured out /how/), and
the other phone with the "NFC Tools" app shows nothing when trying to
read from any of the kumano phones (but then I am also unsure how to
"present" a tag via nfctool, and expected it to be implicit when running
as "initiator").

Debug/testing advice appreciated :)

- Marijn

> ---
>  .../boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi     | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> index 2352dff213fc..9d667bb6f25b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> @@ -428,8 +428,18 @@ &i2c4 {
>  
>  	/* Qcom SMB1355 @ c */
>  	/* Qcom SMB1390 @ 10 */
> -	/* NXP PN553 NFC @ 28 */
>  	/* Qcom FSA4480 USB-C audio switch @ 43 */
> +
> +	nfc@28 {
> +		compatible = "nxp,nxp-nci-i2c";
> +		reg = <0x28>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <47 IRQ_TYPE_EDGE_RISING>;
> +
> +		enable-gpios = <&tlmm 41 GPIO_ACTIVE_HIGH>;
> +		firmware-gpios = <&tlmm 48 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  &i2c7 {
> -- 
> 2.38.1
>