From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6C6C4332F for ; Thu, 22 Dec 2022 10:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235271AbiLVKKq (ORCPT ); Thu, 22 Dec 2022 05:10:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235351AbiLVKKV (ORCPT ); Thu, 22 Dec 2022 05:10:21 -0500 Received: from m-r1.th.seeweb.it (m-r1.th.seeweb.it [IPv6:2001:4b7a:2000:18::170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C2AF1E3C7; Thu, 22 Dec 2022 02:10:15 -0800 (PST) Received: from SoMainline.org (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 64C5E200F3; Thu, 22 Dec 2022 11:10:13 +0100 (CET) Date: Thu, 22 Dec 2022 11:10:12 +0100 From: Marijn Suijten To: Krzysztof Kozlowski Cc: phone-devel@vger.kernel.org, Will Deacon , Joerg Roedel , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Lux Aliaga , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Dmitry Baryshkov , Thierry Reding , Melody Olvera , Greg Kroah-Hartman , Bhupesh Sharma , Douglas Anderson , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt-bindings: arm-smmu: Document smmu-500 binding for SM6125 Message-ID: <20221222101012.ptrrugxj3ksiyitn@SoMainline.org> Mail-Followup-To: Marijn Suijten , Krzysztof Kozlowski , phone-devel@vger.kernel.org, Will Deacon , Joerg Roedel , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Lux Aliaga , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Dmitry Baryshkov , Thierry Reding , Melody Olvera , Greg Kroah-Hartman , Bhupesh Sharma , Douglas Anderson , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20221216215819.1164973-1-marijn.suijten@somainline.org> <20221216215819.1164973-2-marijn.suijten@somainline.org> <306709f8-7d45-9b76-f95b-1b3088d37a78@linaro.org> <6d263321-782d-9d9c-4fdf-8bcf5b280779@linaro.org> <20221219192839.6oqialqqw5xw5fxa@SoMainline.org> <20221222082353.lhdw7h3pdqyyvsxy@SoMainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-12-22 10:29:40, Krzysztof Kozlowski wrote: > On 22/12/2022 09:23, Marijn Suijten wrote: > > On 2022-12-20 10:52:49, Krzysztof Kozlowski wrote: > >> On 19/12/2022 20:28, Marijn Suijten wrote: > >>> On 2022-12-19 10:09:03, Krzysztof Kozlowski wrote: > >>>> On 19/12/2022 10:07, Krzysztof Kozlowski wrote: > >>>>> On 16/12/2022 22:58, Marijn Suijten wrote: > >>>>>> From: Martin Botka > >>>>>> > >>>>>> Document smmu-500 compatibility with the SM6125 SoC. > >>>>>> > >>>>> > >>>>> Acked-by: Krzysztof Kozlowski > >>>> > >>>> Wait, not entirely... no constraints for clocks and regs? > >>> > >>> Quite odd that there is no warning for my DT patch as it clearly > >>> requires at least one clock... > > > > Again, any idea why there's no warning for this DT mismatching minItems: > > 1 for clocks, clock-names and power-domains? > > I don't know what do you have in DT and what is mismatched. Why there > should be a warning? There is: clock-names: minItems: 1 maxItems: 7 clocks: minItems: 1 maxItems: 7 But I did not provide _any_ (see patch 2 of this series). Shouldn't that trigger a warning? > >>> Irrespective of that downstream doesn't define any (nor power domains). > >>> How should we proceed? > >> > >> Binding now has constraints for clocks so at least that should be added > >> to your variant. > > > > And that should be: > > > > clock-names: false > > clocks: false > > power-domains: false > > > > Because this board does declare have any, at least not when going off of > > downstream DT? > > I'll add it for existing platforms, so you can rebase on top. Thanks, will do! - Marijn