From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6135EC6379F for ; Fri, 13 Jan 2023 20:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjAMUP3 (ORCPT ); Fri, 13 Jan 2023 15:15:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjAMUPY (ORCPT ); Fri, 13 Jan 2023 15:15:24 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C01088A3B for ; Fri, 13 Jan 2023 12:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673640875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V54z6rLYX2VOlDzoy2qPL6F5L+cbM84DrtMdlJiXWFI=; b=atfVUG9Z3hGI7QjsQHmobX6j8/hErnJmStZii0Ae9r5sU/LNHdnCwLp6qFr6o0kk0MSsr2 ys5w7fA/PW7oCIauuW42Jk4ZQWLxErnBOPEhpoBusXoNNWCYXSxT3Q7GKhoeFccpZnUlvG GmOvbY2g139j8S/08a029E7LVhiv4q4= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-292-LZYU2XdDN3OleVHT3NUNqg-1; Fri, 13 Jan 2023 15:14:34 -0500 X-MC-Unique: LZYU2XdDN3OleVHT3NUNqg-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-15b907e71edso6911032fac.17 for ; Fri, 13 Jan 2023 12:14:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V54z6rLYX2VOlDzoy2qPL6F5L+cbM84DrtMdlJiXWFI=; b=aq+5Ugms4IpJR/oTFVIZKz53ad5DBP6cPF5jQFuK6oeHaDzQ4xvxmO4FbjXEvRVIC1 hETVQhmHfBG7jjwSsIXgU18uCxA8A50XTHIfmNJD7vrPyVL1vk89HWLD6T0T0zFqmZhv B5q1onHZZ1MlW816elPcl5RTfPFRG/wCqjP/XBFxobXX/NyzdfjM4q5FCEUE60YLPs++ RB86qfI7bhX+yzLS+rBIYGjqX4j5DvFsy6ujvkZ47xwV2SVWj3jJifKySwp6ONZUGFAs /MX6WvwMb9m87Cre546zOglZdeEM1fmC6/f9Qx+jKXQBxqBmOdgwOOehhsEmL3OiCbP2 SgzA== X-Gm-Message-State: AFqh2kqZYj6YwsPZS7vgAnhZjFkKteujdp94svxsBk+cBIYWe14dbyOq XYVxmtSYOfJ/z7U99WIMPTNquuf0ppN0m8Wa4uiysxJ5Xf14/ZiByM5V1n5aSe56t2VXbzJMZCg mSkrOJxYbKKilDEPlKZM/QCHkkA== X-Received: by 2002:a4a:840b:0:b0:4a3:7135:d6e6 with SMTP id l11-20020a4a840b000000b004a37135d6e6mr27292075oog.2.1673640873202; Fri, 13 Jan 2023 12:14:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXs9qurBkZ0NHbx4xl/ouYmunfvjOxLSlaDzU3BupNJH5CSmq96OKqhSoII4T2zcJaJLgYoaaA== X-Received: by 2002:a4a:840b:0:b0:4a3:7135:d6e6 with SMTP id l11-20020a4a840b000000b004a37135d6e6mr27292066oog.2.1673640872939; Fri, 13 Jan 2023 12:14:32 -0800 (PST) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id y139-20020a4a4591000000b004c60069d1fbsm3018728ooa.11.2023.01.13.12.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 12:14:32 -0800 (PST) Date: Fri, 13 Jan 2023 14:14:30 -0600 From: Andrew Halaney To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Message-ID: <20230113201430.c4oa46ry2bx2axhd@halaney-x13s> References: <20230113041038.4188995-1-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113041038.4188995-1-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Signed-off-by: Bjorn Andersson Tested-by: Andrew Halaney # sc8280xp-lenovo-thinkpad-x13s I've booted with this (and without clk_ignore_unused) a few times today and have been working with on the machine without any apparent issues. Thanks! It is nice to have to modify less of the kernel cli to boot. > --- > drivers/clk/qcom/dispcc-sc8280xp.c | 1 + > drivers/clk/qcom/gcc-sc8280xp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c > index 167470beb369..c84a6481b879 100644 > --- a/drivers/clk/qcom/dispcc-sc8280xp.c > +++ b/drivers/clk/qcom/dispcc-sc8280xp.c > @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { > .driver = { > .name = "disp_cc-sc8280xp", > .of_match_table = disp_cc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b3198784e1c3..f4fdc5b9663c 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { > .driver = { > .name = "gcc-sc8280xp", > .of_match_table = gcc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > -- > 2.37.3 >