Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] nvmem: qcom-spmi-sdam: fix module autoloading
Date: Thu, 26 Jan 2023 10:10:02 -0600	[thread overview]
Message-ID: <20230126161002.74wbgoo7ytx4cyoi@builder.lan> (raw)
In-Reply-To: <20230126133034.27491-1-johan+linaro@kernel.org>

On Thu, Jan 26, 2023 at 02:30:32PM +0100, Johan Hovold wrote:
> The Qualcomm SDAM nvme driver did not have a module device table, which
> prevents userspace from autoloading the driver when built as a module.
> 
> The driver was also being registered at subsys init time when built in
> despite the fact that it can also be built as a module, which makes
> little sense. There are currently no in-tree users of this driver and
> there's no reason why we can't just let driver core sort out the probe
> order.
> 
> Note that this driver will be used to implement support for the PMIC RTC
> on Qualcomm platforms where the time registers are read-only (sic).
> 
> Johan
> 

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> 
> Johan Hovold (2):
>   nvmem: qcom-spmi-sdam: fix module autoloading
>   nvmem: qcom-spmi-sdam: register at device init time
> 
>  drivers/nvmem/qcom-spmi-sdam.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> -- 
> 2.39.1
> 

  parent reply	other threads:[~2023-01-26 16:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 13:30 [PATCH 0/2] nvmem: qcom-spmi-sdam: fix module autoloading Johan Hovold
2023-01-26 13:30 ` [PATCH 1/2] " Johan Hovold
2023-01-26 13:30 ` [PATCH 2/2] nvmem: qcom-spmi-sdam: register at device init time Johan Hovold
2023-01-26 16:10 ` Bjorn Andersson [this message]
2023-01-27  9:30 ` [PATCH 0/2] nvmem: qcom-spmi-sdam: fix module autoloading Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126161002.74wbgoo7ytx4cyoi@builder.lan \
    --to=andersson@kernel.org \
    --cc=agross@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox