From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: caleb.connolly@linaro.org, mka@chromium.org,
evgreen@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 6/8] net: ipa: greater timer granularity options
Date: Mon, 30 Jan 2023 15:01:56 -0600 [thread overview]
Message-ID: <20230130210158.4126129-7-elder@linaro.org> (raw)
In-Reply-To: <20230130210158.4126129-1-elder@linaro.org>
Starting with IPA v5.0, the head-of-line blocking timer has more
than two pulse generators available to define timer granularity.
To prepare for that, change the way the field value is encoded
to use ipa_reg_encode() rather than ipa_reg_bit().
The aggregation granularity selection could (in principle) also use
an additional pulse generator starting with IPA v5.0. Encode the
AGGR_GRAN_SEL field differently to allow that as well.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_endpoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 8909ba8bfd0e9..c029209191d41 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c
@@ -965,7 +965,7 @@ static u32 aggr_time_limit_encode(struct ipa *ipa, const struct ipa_reg *reg,
ret = ipa_qtime_val(microseconds, max);
if (ret < 0) {
val = -ret;
- gran_sel = ipa_reg_bit(reg, AGGR_GRAN_SEL);
+ gran_sel = ipa_reg_encode(reg, AGGR_GRAN_SEL, 1);
} else {
val = ret;
gran_sel = 0;
@@ -1057,7 +1057,7 @@ static u32 hol_block_timer_encode(struct ipa *ipa, const struct ipa_reg *reg,
ret = ipa_qtime_val(microseconds, max);
if (ret < 0) {
val = -ret;
- gran_sel = ipa_reg_bit(reg, TIMER_GRAN_SEL);
+ gran_sel = ipa_reg_encode(reg, TIMER_GRAN_SEL, 1);
} else {
val = ret;
gran_sel = 0;
--
2.34.1
next prev parent reply other threads:[~2023-01-30 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 21:01 [PATCH net-next 0/8] net: ipa: remaining IPA v5.0 support Alex Elder
2023-01-30 21:01 ` [PATCH net-next 1/8] net: ipa: support more endpoints Alex Elder
2023-01-30 21:01 ` [PATCH net-next 2/8] net: ipa: extend endpoints in packet init command Alex Elder
2023-01-30 21:01 ` [PATCH net-next 3/8] net: ipa: define IPA v5.0+ registers Alex Elder
2023-01-30 21:01 ` [PATCH net-next 4/8] net: ipa: update table cache flushing Alex Elder
2023-01-30 21:01 ` [PATCH net-next 5/8] net: ipa: support zeroing new cache tables Alex Elder
2023-01-30 21:01 ` Alex Elder [this message]
2023-01-30 21:01 ` [PATCH net-next 7/8] net: ipa: support a third pulse register Alex Elder
2023-01-30 21:01 ` [PATCH net-next 8/8] net: ipa: define two new memory regions Alex Elder
2023-01-31 11:40 ` [PATCH net-next 0/8] net: ipa: remaining IPA v5.0 support Leon Romanovsky
2023-02-01 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130210158.4126129-7-elder@linaro.org \
--to=elder@linaro.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox