From: Marijn Suijten <marijn.suijten@somainline.org>
To: Kalyan Thota <quic_kalyant@quicinc.com>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robdclark@chromium.org,
dianders@chromium.org, swboyd@chromium.org,
quic_vpolimer@quicinc.com, dmitry.baryshkov@linaro.org,
quic_abhinavk@quicinc.com
Subject: Re: [v1 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request
Date: Wed, 1 Feb 2023 12:26:31 +0100 [thread overview]
Message-ID: <20230201112631.mgwuboehrwdefqnd@SoMainline.org> (raw)
In-Reply-To: <20230201111604.htgczy6yvdkywhvl@SoMainline.org>
On 2023-02-01 12:16:05, Marijn Suijten wrote:
<snip>
> > + if (dpu_kms->catalog->dspp &&
> > + crtc_state->ctm && (dpu_kms->catalog->dspp_count >= topology.num_lm))
>
> Multiline-if-clause is typically indented with two tabs, not a half tab
> (4 spaces).
Hmm, Dmitry requested indent-to-opening-parenthesis in v1 instead; and
the majority of dpu1 uses the worst version of all: indent with a single
tab so that the contents line up with the code block below. Dmitry,
I'll leave final say to you (and fix it up in my own DPU series
accordingly too).
- Marijn
next prev parent reply other threads:[~2023-02-01 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 15:21 [PATCH 0/3] Reserve dspps based on user request Kalyan Thota
2023-01-30 15:21 ` [v1 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release Kalyan Thota
2023-02-01 11:10 ` Marijn Suijten
2023-02-01 11:21 ` Marijn Suijten
2023-01-30 15:21 ` [v1 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request Kalyan Thota
2023-01-30 18:36 ` Dmitry Baryshkov
2023-02-01 11:16 ` Marijn Suijten
2023-02-01 11:26 ` Marijn Suijten [this message]
2023-02-01 13:49 ` Dmitry Baryshkov
2023-02-01 13:48 ` Dmitry Baryshkov
2023-02-01 15:10 ` Marijn Suijten
2023-01-30 15:21 ` [v1 3/3] drm/msm/disp/dpu1: reserve the resources on topology change Kalyan Thota
2023-01-30 19:17 ` Dmitry Baryshkov
2023-02-02 4:22 ` kernel test robot
2023-02-02 14:08 ` kernel test robot
2023-01-30 19:18 ` [PATCH 0/3] Reserve dspps based on user request Dmitry Baryshkov
2023-02-01 11:01 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201112631.mgwuboehrwdefqnd@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox