From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>, Iskren Chernev <me@iskren.info>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example
Date: Thu, 2 Feb 2023 18:01:30 -0600 [thread overview]
Message-ID: <20230203000130.GA2934311-robh@kernel.org> (raw)
In-Reply-To: <20230202104452.299048-3-krzysztof.kozlowski@linaro.org>
On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote:
> The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern
> and gpio-ranges in the example.
>
> Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> index 449e6e34be61..85082adc1811 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> @@ -63,7 +63,7 @@ $defs:
> subnode.
> items:
> oneOf:
> - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$"
> + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
> - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
> sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1,
> qdsd_data2, qdsd_data3 ]
> @@ -127,7 +127,7 @@ examples:
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 0 117>;
> + gpio-ranges = <&tlmm 0 0 113>;
I thought 112 was the max?
> interrupt-controller;
> #interrupt-cells = <2>;
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-03 0:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 10:44 [PATCH v2 00/10] pinctrl/ARM/arm64: qcom: correct TLMM gpio-ranges and GPIO pin names Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 01/10] dt-bindings: pinctrl: qcom,msm8226: correct GPIO name pattern Krzysztof Kozlowski
2023-02-02 17:31 ` Luca Weiss
2023-02-03 0:00 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example Krzysztof Kozlowski
2023-02-03 0:01 ` Rob Herring [this message]
2023-02-03 0:03 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 03/10] dt-bindings: pinctrl: qcom,sm6375: " Krzysztof Kozlowski
2023-02-03 0:04 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 04/10] dt-bindings: pinctrl: qcom,msm8953: correct GPIO name pattern Krzysztof Kozlowski
2023-02-02 17:33 ` Luca Weiss
2023-02-03 0:04 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 05/10] dt-bindings: pinctrl: qcom,sdx55: " Krzysztof Kozlowski
2023-02-03 0:04 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 06/10] dt-bindings: pinctrl: qcom,msm8994: correct number of GPIOs Krzysztof Kozlowski
2023-02-03 0:05 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 07/10] dt-bindings: pinctrl: qcom: correct gpio-ranges in examples Krzysztof Kozlowski
2023-02-03 0:05 ` Rob Herring
2023-02-03 7:17 ` (subset) " Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 08/10] ARM: dts: qcom: sdx55: correct TLMM gpio-ranges Krzysztof Kozlowski
2023-02-02 10:44 ` [PATCH v2 09/10] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2023-02-02 17:36 ` Luca Weiss
2023-02-02 10:44 ` [PATCH v2 10/10] arm64: dts: qcom: sm6115: " Krzysztof Kozlowski
2023-02-06 11:28 ` Iskren Chernev
2023-02-02 22:28 ` [PATCH v2 00/10] pinctrl/ARM/arm64: qcom: correct TLMM gpio-ranges and GPIO pin names Linus Walleij
2023-02-03 7:11 ` Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203000130.GA2934311-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=me@iskren.info \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox