From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
"Johan Hovold" <johan+linaro@kernel.org>
Subject: [PATCH v2 23/23] interconnect: drop unused icc_link_destroy() interface
Date: Mon, 6 Mar 2023 08:56:51 +0100 [thread overview]
Message-ID: <20230306075651.2449-24-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230306075651.2449-1-johan+linaro@kernel.org>
Now that the link array is deallocated when destroying nodes and the
explicit link removal has been dropped from the exynos driver there are
no further users of and no need for the icc_link_destroy() interface.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/interconnect/core.c | 46 ---------------------------
include/linux/interconnect-provider.h | 6 ----
2 files changed, 52 deletions(-)
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index fd12f109c05e..6315d4256ac1 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -862,52 +862,6 @@ int icc_link_create(struct icc_node *node, const int dst_id)
}
EXPORT_SYMBOL_GPL(icc_link_create);
-/**
- * icc_link_destroy() - destroy a link between two nodes
- * @src: pointer to source node
- * @dst: pointer to destination node
- *
- * Return: 0 on success, or an error code otherwise
- */
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
- struct icc_node **new;
- size_t slot;
- int ret = 0;
-
- if (IS_ERR_OR_NULL(src))
- return -EINVAL;
-
- if (IS_ERR_OR_NULL(dst))
- return -EINVAL;
-
- mutex_lock(&icc_lock);
-
- for (slot = 0; slot < src->num_links; slot++)
- if (src->links[slot] == dst)
- break;
-
- if (WARN_ON(slot == src->num_links)) {
- ret = -ENXIO;
- goto out;
- }
-
- src->links[slot] = src->links[--src->num_links];
-
- new = krealloc(src->links, src->num_links * sizeof(*src->links),
- GFP_KERNEL);
- if (new)
- src->links = new;
- else
- ret = -ENOMEM;
-
-out:
- mutex_unlock(&icc_lock);
-
- return ret;
-}
-EXPORT_SYMBOL_GPL(icc_link_destroy);
-
/**
* icc_node_add() - add interconnect node to interconnect provider
* @node: pointer to the interconnect node
diff --git a/include/linux/interconnect-provider.h b/include/linux/interconnect-provider.h
index b9af9016a95e..e6d8aca6886d 100644
--- a/include/linux/interconnect-provider.h
+++ b/include/linux/interconnect-provider.h
@@ -118,7 +118,6 @@ int icc_std_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
struct icc_node *icc_node_create(int id);
void icc_node_destroy(int id);
int icc_link_create(struct icc_node *node, const int dst_id);
-int icc_link_destroy(struct icc_node *src, struct icc_node *dst);
void icc_node_add(struct icc_node *node, struct icc_provider *provider);
void icc_node_del(struct icc_node *node);
int icc_nodes_remove(struct icc_provider *provider);
@@ -150,11 +149,6 @@ static inline int icc_link_create(struct icc_node *node, const int dst_id)
return -ENOTSUPP;
}
-static inline int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
-{
- return -ENOTSUPP;
-}
-
static inline void icc_node_add(struct icc_node *node, struct icc_provider *provider)
{
}
--
2.39.2
prev parent reply other threads:[~2023-03-06 7:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:56 [PATCH v2 00/23] interconnect: fix racy provider registration Johan Hovold
2023-03-06 7:56 ` [PATCH v2 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold
2023-03-07 9:42 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 03/23] interconnect: fix provider registration API Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 04/23] interconnect: imx: fix registration race Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 10:25 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 05/23] interconnect: qcom: osm-l3: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` [PATCH v2 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` [PATCH v2 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 11/23] interconnect: qcom: msm8974: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 12/23] interconnect: qcom: sm8450: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 13/23] interconnect: qcom: sm8550: " Johan Hovold
2023-03-06 9:03 ` Abel Vesa
2023-03-06 9:34 ` Johan Hovold
2023-03-06 9:39 ` Abel Vesa
2023-03-06 10:04 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold
2023-03-06 7:56 ` [PATCH v2 15/23] interconnect: exynos: fix registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold
2023-03-06 7:56 ` [PATCH v2 17/23] memory: tegra: fix interconnect registration race Johan Hovold
2023-03-06 7:56 ` [PATCH v2 18/23] memory: tegra124-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 19/23] memory: tegra20-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 20/23] memory: tegra30-emc: " Johan Hovold
2023-03-06 7:56 ` [PATCH v2 21/23] interconnect: drop racy registration API Johan Hovold
2023-03-06 7:56 ` [PATCH v2 22/23] interconnect: drop unused icc_get() interface Johan Hovold
2023-03-06 7:56 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306075651.2449-24-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=a.swigon@samsung.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox