From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Heinz Wiesinger <pprkut@slackware.com>
Cc: quic_schowdhu@quicinc.com, andersson@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
mhiramat@kernel.org, quic_rjendra@quicinc.com,
quic_saipraka@quicinc.com, quic_sibis@quicinc.com
Subject: Re: [PATCH V1] bootconfig: Increase max nodes of bootconfig from 1024 to 8192 for DCC support
Date: Mon, 13 Mar 2023 15:02:12 +0900 [thread overview]
Message-ID: <20230313150212.4ff2bc19f36469b9f9304605@kernel.org> (raw)
In-Reply-To: <2463802.XAFRqVoOGU@amaterasu.liwjatan.org>
On Sun, 12 Mar 2023 12:49:44 +0100
Heinz Wiesinger <pprkut@slackware.com> wrote:
> Hi everyone,
Oops, thanks for pointing it out. I have to run the test in the test environment...
>
> It looks like this broke the bootconfig tests (tools/bootconfig/test-
> bootconfig.sh), tested on 6.1.18:
>
> Max node number check
> test case 12 (./bootconfig -a ./temp-HCfT.bconf ./initrd-NGHv)...
> Apply ./temp-HCfT.bconf to ./initrd-NGHv
> Number of nodes: 1024
> Size: 8110 bytes
> Checksum: 599485
> \t\t[OK]
> test case 13 (./bootconfig -a ./temp-HCfT.bconf ./initrd-NGHv)...
> Apply ./temp-HCfT.bconf to ./initrd-NGHv
> Number of nodes: 1025
> Size: 8118 bytes
> Checksum: 600212
> \t\t[NG]
Yes, it needs to test with 8192 and 8193 nodes. Those are
boundary checker.
Thanks!
>
> When I adjust the max node number for the tests to 8192, test case 13 passes,
> but test case 12 then fails:
>
> Max node number check
> test case 12 (./bootconfig -a ./temp-qZHF.bconf ./initrd-0v99)...
> Error: Config data is too big.
> \t\t[NG]
> test case 13 (./bootconfig -a ./temp-qZHF.bconf ./initrd-0v99)...
> Error: Config data is too big.
> \t\t[OK]
Ah, it hits the size limitation. :D
Each node consumes "node%d\n" = 6-11 bytes, and 11 bytes*8k = 88k bytes > 32K bytes.
So, for making 8k nodes (including delimiter), we need to use 3 random alphabets for
node name. (26^3 = 17576)
Let me fix that and thanks for report!
>
> Grs,
> Heinz
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-03-13 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 5:04 [PATCH V1] bootconfig: Increase max nodes of bootconfig from 1024 to 8192 for DCC support Souradeep Chowdhury
2023-01-24 5:44 ` Masami Hiramatsu
2023-03-12 11:49 ` Heinz Wiesinger
2023-03-13 6:02 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313150212.4ff2bc19f36469b9f9304605@kernel.org \
--to=mhiramat@kernel.org \
--cc=andersson@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pprkut@slackware.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_sibis@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox