Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers

Johan Hovold
2023-04-03T13:11:35Z

On Mon, Apr 03, 2023 at 02:46:41PM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2023 14:33, Krzysztof Kozlowski wrote:
> > On 03/04/2023 12:54, Johan Hovold wrote:

> >> The problem is that the driver was updated before the binding was so the
> >> above mentioned probe error has been there since this file was merged.
> >
> > I grepped and that commit did not have such compatible. Are you saying
> > that the kernel which was released with this commit already had that
> > compatible in driver (through different merge/tree)?
>
> So I double checked, the commit ccd3517faf18 (which is being "fixed")
> was introduced in v6.0-rc1. v6.0-rc1 did not have "qcom,pmk8350-pon"
> compatible, thus it could not be fixed that way. Therefore this cannot
> be logically fix for that commit from that release.

Now you're just making shit up. A fix is a fix for mainline, period. If
someone decides to backport a fix from mainline then that fix may need
to be adapted.

That said, sometimes some of us do take the state of previous versions
of the kernel into account when developing patches in order to
facilitate backports. That's a different thing and certainly not
something that is required to fix an issue in mainline.

Johan