Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers

Konrad Dybcio
2023-03-27T14:00:11Z

On 27.03.2023 14:29, Johan Hovold wrote:
> The pmk8280 PMIC PON peripheral is gen3 and uses two sets of registers;
> hlos and pbs.
>
> This specifically fixes the following error message during boot when the
> pbs registers are not defined:
>
> PON_PBS address missing, can't read HW debounce time
>
> Note that this also enables the spurious interrupt workaround introduced
> by commit 0b65118e6ba3 ("Input: pm8941-pwrkey - add software key press
> debouncing support") (which may or may not be needed).
>
> Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> index c35e7f6bd657..a0ba535bb6c9 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> @@ -59,8 +59,9 @@ pmk8280: pmic@0 {
> #size-cells = <0>;
>
> pmk8280_pon: pon@1300 {
> - compatible = "qcom,pm8998-pon";
> - reg = <0x1300>;
> + compatible = "qcom,pmk8350-pon";
> + reg = <0x1300>, <0x800>;
> + reg-names = "hlos", "pbs";
>
> pmk8280_pon_pwrkey: pwrkey {
> compatible = "qcom,pmk8350-pwrkey";