Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers

Johan Hovold
2023-04-03T14:33:37Z

On Mon, Apr 03, 2023 at 03:47:28PM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2023 15:11, Johan Hovold wrote:
> > On Mon, Apr 03, 2023 at 02:46:41PM +0200, Krzysztof Kozlowski wrote:
> >> On 03/04/2023 14:33, Krzysztof Kozlowski wrote:
> >>> On 03/04/2023 12:54, Johan Hovold wrote:
> >
> >>>> The problem is that the driver was updated before the binding was so the
> >>>> above mentioned probe error has been there since this file was merged.
> >>>
> >>> I grepped and that commit did not have such compatible. Are you saying
> >>> that the kernel which was released with this commit already had that
> >>> compatible in driver (through different merge/tree)?
> >>
> >> So I double checked, the commit ccd3517faf18 (which is being "fixed")
> >> was introduced in v6.0-rc1. v6.0-rc1 did not have "qcom,pmk8350-pon"
> >> compatible, thus it could not be fixed that way. Therefore this cannot
> >> be logically fix for that commit from that release.
> >
> > Now you're just making shit up. A fix is a fix for mainline, period. If
>
> Since this is your second mail in such tone and such phrases, I am not
> going to keep discussing this. Regardless of differences in opinion, you
> should keep the tone appropriate.

Yeah, sorry about that. But please do consider how your own choice of
words come across at times.

I agree that in the end it wasn't that clear cut as the state of the
binding and driver was inconsistent in 5.19 (and 6.0), and if this had
been an important fix that should be backported to trees where this
mattered then that may have had to be taken into account.

Johan