From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org, linux-kernel@vger.kernel.org,
bhupesh.linux@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add base qrb4210-rb2 board dts
Date: Mon, 10 Apr 2023 10:12:15 -0700 [thread overview]
Message-ID: <20230410171215.t65hic7uveeayfja@ripper> (raw)
In-Reply-To: <79731f2a-83e5-1e35-d450-456492cc5df2@linaro.org>
On Thu, Mar 16, 2023 at 12:52:10AM +0100, Konrad Dybcio wrote:
>
>
> On 15.03.2023 23:36, Bjorn Andersson wrote:
> > On Thu, Mar 16, 2023 at 02:31:45AM +0530, Bhupesh Sharma wrote:
> >> Add DTS for Qualcomm qrb4210-rb2 board which uses SM4250 SoC.
> >>
> >> This adds debug uart, emmc, uSD and tlmm support along with
> >> regulators found on this board.
> >>
> >> Also defines the 'xo_board' and 'sleep_clk' frequencies for
> >> this board.
> >>
> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> >> ---
> [...]
>
> >> + vmmc-supply = <&vreg_l24a_2p96>;
> >
> > Is there any reason why this platform doesn't require the vmmc supply to
> > be driven to HPM? This has traditionally been coming back biting us
> > through some stability issues later.
> Do we even support HPM/LPM on SMD RPM?
>
We support specifying the load, which will trickle down to have the
HPM/LPM effect. You can find an example of this, with motivation in [1].
PS. While looking for an example I found [2]. regulator-system-load
doesn't do anything unless regulator-allow-set-load is defined...
[1] e38161bd325e ("arm64: dts: apq8096-db820c: Increase load on l21 for SDCARD")
[2] 1d99fee382a6 ("arm64: dts: qcom: sdm845-tama: Add regulator-system-load to l14a/l28a")
Regards,
Bjorn
prev parent reply other threads:[~2023-04-10 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 21:01 [PATCH v2 0/2] arm64: dts: qcom: Add Qualcomm RB2 board dts Bhupesh Sharma
2023-03-15 21:01 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Document the Qualcomm qrb4210-rb2 board Bhupesh Sharma
2023-03-16 7:29 ` Krzysztof Kozlowski
2023-03-15 21:01 ` [PATCH v2 2/2] arm64: dts: qcom: Add base qrb4210-rb2 board dts Bhupesh Sharma
2023-03-15 22:36 ` Bjorn Andersson
2023-03-15 23:52 ` Konrad Dybcio
2023-04-10 16:53 ` Bhupesh Sharma
2023-04-10 17:12 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410171215.t65hic7uveeayfja@ripper \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox