Re: [net-next PATCH v7 05/16] net: phy: Add a binding for PHY LEDs

Florian Fainelli
2023-04-17T18:26:46Z

On 4/17/23 08:17, Christian Marangi wrote:
> From: Andrew Lunn <andrew@lunn.ch>
>
> Define common binding parsing for all PHY drivers with LEDs using
> phylib. Parse the DT as part of the phy_probe and add LEDs to the
> linux LED class infrastructure. For the moment, provide a dummy
> brightness function, which will later be replaced with a call into the
> PHY driver. This allows testing since the LED core might otherwise
> reject an LED whose brightness cannot be set.
>
> Add a dependency on LED_CLASS. It either needs to be built in, or not
> enabled, since a modular build can result in linker errors.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian