From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB79C6FD18 for ; Tue, 18 Apr 2023 16:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232588AbjDRQxU (ORCPT ); Tue, 18 Apr 2023 12:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232346AbjDRQxP (ORCPT ); Tue, 18 Apr 2023 12:53:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47DAE46BA for ; Tue, 18 Apr 2023 09:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681836745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m4XuvKNkvXzZc1+3hTfEGj/qcp3I6s5wJfqCgvZMlpk=; b=hhKg04mZguhAukimq5/LODR7Idgj2J2Sv2AWnxz019zTNIlMpUvVCD6HtH5EQu3OAk0pQr o+0Wu+IZtr0f2eFIsGbxDbHMmIgPHaLVZCegwB96epMeCvB9NC1lzleCpVcRR6FM6ppwaU W7Fw/qMjXGx26GnoYIGIxmorYeWOggg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-BR7lpR6fNIGEgdAmXEELiw-1; Tue, 18 Apr 2023 12:52:23 -0400 X-MC-Unique: BR7lpR6fNIGEgdAmXEELiw-1 Received: by mail-qv1-f69.google.com with SMTP id a5-20020a0cefc5000000b005ef05a3b13bso8628405qvt.23 for ; Tue, 18 Apr 2023 09:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681836742; x=1684428742; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m4XuvKNkvXzZc1+3hTfEGj/qcp3I6s5wJfqCgvZMlpk=; b=b33sehdIU6WbWPaG+1tgckbcNKIE80x0N6Tgf5M/m5vxVmc8S/72orArcudg1Z8yoE yvZbRZkCcR08LRf8ne6Hl+G1jEh5JIQj6Y1y84wpzDrLzP/4tZ9VAPHfF6l7BaK66lFI OHeutxVXlAD1/PSNk4hg1RlGjXi90oWQlNlhiJPC4Vv1ocERbykp669cmrr6FywI3fYe hZLr4ulGZPForPMRL3rLRCDlkOWeYlfXSRogeuFV4gubkNMilNOf0GbHWoAymxTNQjO+ 3j9+3JNuPvhGtM5VcBbj+pl6+OYapczxEtTsgzxnIsuzIsImfbpg9KnF8r+0vK4NLRyo 7Z4w== X-Gm-Message-State: AAQBX9egn8IVmJAFmbj+2zCVoQR6n3I4B6VHA+RgRXKgdm4vFSqMDpGO oqabjGmmqzTVa3iXSb6SHUOrt7kldI5dsEt+FQZoQSM8s7xZ41aKwk+r9UsTRhlP7ZFKkqJAl1m nut30anrvYYiGc7NaLfaeE0yhMq4vattXUME/ X-Received: by 2002:ac8:5c09:0:b0:3e4:db8e:93a3 with SMTP id i9-20020ac85c09000000b003e4db8e93a3mr1051623qti.7.1681836742457; Tue, 18 Apr 2023 09:52:22 -0700 (PDT) X-Google-Smtp-Source: AKy350b8iSTRAO2qFyeWH4GJpl/wFRinI09KrBbA/lx+iW+RGd1xxBPEiWih2p3z6gxdbX7FlxYBMQ== X-Received: by 2002:ac8:5c09:0:b0:3e4:db8e:93a3 with SMTP id i9-20020ac85c09000000b003e4db8e93a3mr1051594qti.7.1681836742197; Tue, 18 Apr 2023 09:52:22 -0700 (PDT) Received: from localhost (pool-71-184-142-128.bstnma.fios.verizon.net. [71.184.142.128]) by smtp.gmail.com with ESMTPSA id a145-20020ae9e897000000b0074d02ac1c19sm2468991qkg.15.2023.04.18.09.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 09:52:21 -0700 (PDT) Date: Tue, 18 Apr 2023 12:52:24 -0400 From: Eric Chanudet To: Bartosz Golaszewski Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Catalin Marinas , Will Deacon , Arnd Bergmann , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Shazad Hussain Subject: Re: [PATCH v4 2/5] arm64: dts: qcom: sa8775p: add the pcie smmu node Message-ID: <20230418165224.vmok75fwcjqdxspe@echanude> References: <20230417125844.400782-1-brgl@bgdev.pl> <20230417125844.400782-3-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417125844.400782-3-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Apr 17, 2023 at 02:58:41PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the PCIe SMMU node for sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 74 +++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) Hi Bartosz, Adding Shazad. I upgraded to the meta Shazad mentioned in v2[1], but I still get a synchronous external abort on reboot: [ 8.285500] arm-smmu 15200000.iommu: disabling translation 4 12.145913 Injecting instruction/data abort to VM 3, original ESR_EL2 = 0x93800047, fault VA = 0xffff80000a080000, fault IPA = 0x15200000, ELR_EL2 = 0xffffae99a42c96e4 [ 8.310145] Internal error: synchronous external abort: 0000000096000010 [#1] PREEMPT SMP [ 8.316561] Modules linked in: qcom_pon crct10dif_ce gpucc_sa8775p i2c_qcom_geni spi_geni_qcom ufs_qcom phy_qcom_qmp_ufs socinfo fuse ipv6 [ 8.331284] CPU: 4 PID: 1 Comm: systemd-shutdow Not tainted 6.3.0-rc7-next-20230417-00014-g93340f644112 #136 [ 8.341365] Hardware name: Qualcomm SA8775P Ride (DT) [ 8.346555] pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 8.353705] pc : arm_smmu_device_shutdown+0x64/0x154 [ 8.358815] lr : arm_smmu_device_shutdown+0x3c/0x154 [ 8.363915] sp : ffff80000805bc00 [ 8.367322] x29: ffff80000805bc00 x28: ffff69c250ca0000 x27: 0000000000000000 [ 8.374643] x26: ffffae99a53357f8 x25: 0000000000000001 x24: ffffae99a60d5028 [ 8.381963] x23: ffff69c2516ab890 x22: ffffae99a614e218 x21: ffff69c251668c10 [ 8.389283] x20: ffff69c2516ab810 x19: ffff69c251479a80 x18: 0000000000000006 [ 8.396603] x17: 0000000000000014 x16: 0000000000000030 x15: ffff80000805b5d0 [ 8.403923] x14: 0000000000000000 x13: ffffae99a5ce1a28 x12: 00000000000005eb [ 8.411243] x11: 00000000000001f9 x10: ffffae99a5d39a28 x9 : ffffae99a5ce1a28 [ 8.418563] x8 : 00000000ffffefff x7 : ffffae99a5d39a28 x6 : 80000000fffff000 [ 8.425884] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 8.433204] x2 : 0000000000000000 x1 : ffff80000a080000 x0 : 0000000000000001 [ 8.440524] Call trace: [ 8.443039] arm_smmu_device_shutdown+0x64/0x154 [ 8.447784] platform_shutdown+0x24/0x34 [ 8.451821] device_shutdown+0x150/0x258 [ 8.455857] kernel_restart+0x40/0xc0 [ 8.459623] __do_sys_reboot+0x1f0/0x274 [ 8.463656] __arm64_sys_reboot+0x24/0x30 [ 8.467778] invoke_syscall+0x48/0x114 [ 8.471633] el0_svc_common+0x40/0xf4 [ 8.475397] do_el0_svc+0x3c/0x9c [ 8.478806] el0_svc+0x2c/0x84 [ 8.481947] el0t_64_sync_handler+0xf4/0x120 [ 8.486334] el0t_64_sync+0x190/0x194 [ 8.490100] Code: f9400404 b50005e4 f9400661 52800020 (b9000020) [ 8.496361] ---[ end trace 0000000000000000 ]--- [1] https://lore.kernel.org/linux-arm-kernel/24804682-6ead-03b1-8b21-3ac413187c4a@quicinc.com/ > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 2343df7e0ea4..a23175352a20 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -809,6 +809,80 @@ apps_smmu: iommu@15000000 { > ; > }; > > + pcie_smmu: iommu@15200000 { > + compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", "arm,mmu-500"; > + reg = <0x0 0x15200000 0x0 0x80000>; > + #iommu-cells = <2>; > + #global-interrupts = <2>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > intc: interrupt-controller@17a00000 { > compatible = "arm,gic-v3"; > reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ > -- > 2.37.2 > -- Eric Chanudet