* [PATCH 1/3] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953
2023-04-21 21:56 [PATCH 0/3] Add GPIO support to PM8953 PMIC Luca Weiss
@ 2023-04-21 21:56 ` Luca Weiss
2023-04-23 10:56 ` Krzysztof Kozlowski
2023-04-21 21:56 ` [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PM8953 support Luca Weiss
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2023-04-21 21:56 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Luca Weiss
Document the 8 GPIOs found on PM8953.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index eaadd5a9a445..8aaf50181cef 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -49,6 +49,7 @@ properties:
- qcom,pm8921-gpio
- qcom,pm8941-gpio
- qcom,pm8950-gpio
+ - qcom,pm8953-gpio
- qcom,pm8994-gpio
- qcom,pm8998-gpio
- qcom,pma8084-gpio
@@ -175,6 +176,7 @@ allOf:
- qcom,pm8350b-gpio
- qcom,pm8550ve-gpio
- qcom,pm8950-gpio
+ - qcom,pm8953-gpio
- qcom,pmi632-gpio
then:
properties:
@@ -434,6 +436,7 @@ $defs:
- gpio1-gpio44 for pm8921
- gpio1-gpio36 for pm8941
- gpio1-gpio8 for pm8950 (hole on gpio3)
+ - gpio1-gpio8 for pm8953 (hole on gpio3 and gpio6)
- gpio1-gpio22 for pm8994
- gpio1-gpio26 for pm8998
- gpio1-gpio22 for pma8084
--
2.40.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953
2023-04-21 21:56 ` [PATCH 1/3] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953 Luca Weiss
@ 2023-04-23 10:56 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-23 10:56 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 21/04/2023 23:56, Luca Weiss wrote:
> Document the 8 GPIOs found on PM8953.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PM8953 support
2023-04-21 21:56 [PATCH 0/3] Add GPIO support to PM8953 PMIC Luca Weiss
2023-04-21 21:56 ` [PATCH 1/3] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953 Luca Weiss
@ 2023-04-21 21:56 ` Luca Weiss
2023-04-21 21:56 ` [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs Luca Weiss
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Luca Weiss @ 2023-04-21 21:56 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Luca Weiss
Add support for the 8 GPIOs found on PM8953.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 43c7857c06a5..b4cd66886f29 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1229,6 +1229,8 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
/* pm8950 has 8 GPIOs with holes on 3 */
{ .compatible = "qcom,pm8950-gpio", .data = (void *) 8 },
+ /* pm8953 has 8 GPIOs with holes on 3 and 6 */
+ { .compatible = "qcom,pm8953-gpio", .data = (void *) 8 },
{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
--
2.40.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs
2023-04-21 21:56 [PATCH 0/3] Add GPIO support to PM8953 PMIC Luca Weiss
2023-04-21 21:56 ` [PATCH 1/3] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953 Luca Weiss
2023-04-21 21:56 ` [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PM8953 support Luca Weiss
@ 2023-04-21 21:56 ` Luca Weiss
2023-04-22 9:56 ` Konrad Dybcio
2023-05-05 11:47 ` [PATCH 0/3] Add GPIO support to PM8953 PMIC Linus Walleij
2023-05-25 4:54 ` (subset) " Bjorn Andersson
4 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2023-04-21 21:56 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Luca Weiss
Add a node for the GPIOs found on the pm8953.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm64/boot/dts/qcom/pm8953.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi b/arch/arm64/boot/dts/qcom/pm8953.dtsi
index a1d36f9ebbd2..2268daf27fa7 100644
--- a/arch/arm64/boot/dts/qcom/pm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi
@@ -79,6 +79,16 @@ rtc@6000 {
reg-names = "rtc", "alarm";
interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
};
+
+ pm8953_gpios: gpio@c000 {
+ compatible = "qcom,pm8953-gpio", "qcom,spmi-gpio";
+ reg = <0xc000>;
+ gpio-controller;
+ gpio-ranges = <&pm8953_gpios 0 0 8>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};
pmic@1 {
--
2.40.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs
2023-04-21 21:56 ` [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs Luca Weiss
@ 2023-04-22 9:56 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-04-22 9:56 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 21.04.2023 23:56, Luca Weiss wrote:
> Add a node for the GPIOs found on the pm8953.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/pm8953.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi b/arch/arm64/boot/dts/qcom/pm8953.dtsi
> index a1d36f9ebbd2..2268daf27fa7 100644
> --- a/arch/arm64/boot/dts/qcom/pm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi
> @@ -79,6 +79,16 @@ rtc@6000 {
> reg-names = "rtc", "alarm";
> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + pm8953_gpios: gpio@c000 {
> + compatible = "qcom,pm8953-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + gpio-ranges = <&pm8953_gpios 0 0 8>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> };
>
> pmic@1 {
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] Add GPIO support to PM8953 PMIC
2023-04-21 21:56 [PATCH 0/3] Add GPIO support to PM8953 PMIC Luca Weiss
` (2 preceding siblings ...)
2023-04-21 21:56 ` [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs Luca Weiss
@ 2023-05-05 11:47 ` Linus Walleij
2023-05-25 4:54 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2023-05-05 11:47 UTC (permalink / raw)
To: Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Fri, Apr 21, 2023 at 11:56 PM Luca Weiss <luca@z3ntu.xyz> wrote:
> Add support for the 8 GPIOs found on the PM8953 PMIC used with msm8953
> SoC.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
(...)
> Luca Weiss (3):
> dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953
> pinctrl: qcom: spmi-gpio: Add PM8953 support
I applied these two to the pinctrl tree for the v6.5 kernel cycle.
> arm64: dts: qcom: pm8953: add GPIOs
Please funnel this one through the qcom SoC tree (I think Bjorn
will pick it up else poke him).
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: (subset) [PATCH 0/3] Add GPIO support to PM8953 PMIC
2023-04-21 21:56 [PATCH 0/3] Add GPIO support to PM8953 PMIC Luca Weiss
` (3 preceding siblings ...)
2023-05-05 11:47 ` [PATCH 0/3] Add GPIO support to PM8953 PMIC Linus Walleij
@ 2023-05-25 4:54 ` Bjorn Andersson
4 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2023-05-25 4:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, Konrad Dybcio, Rob Herring, Andy Gross,
Luca Weiss, ~postmarketos/upstreaming, phone-devel, Linus Walleij
Cc: linux-kernel, linux-arm-msm, devicetree, linux-gpio
On Fri, 21 Apr 2023 23:56:19 +0200, Luca Weiss wrote:
> Add support for the 8 GPIOs found on the PM8953 PMIC used with msm8953
> SoC.
>
>
Applied, thanks!
[3/3] arm64: dts: qcom: pm8953: add GPIOs
commit: 5a60e72c3eff0747cc779b8067cd795acf6beecd
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread