From: Borislav Petkov <bp@alien8.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: andersson@kernel.org, mchehab@kernel.org, james.morse@arm.com,
rric@kernel.org, linux-arm-msm@vger.kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.baryshkov@linaro.org, stable@vger.kernel.org
Subject: Re: [RESEND PATCH v7 2/2] EDAC/qcom: Get rid of hardcoded register offsets
Date: Wed, 17 May 2023 12:38:15 +0200 [thread overview]
Message-ID: <20230517103815.GCZGSul9wCk4K8/XkN@fat_crate.local> (raw)
In-Reply-To: <20230517062859.57371-3-manivannan.sadhasivam@linaro.org>
On Wed, May 17, 2023 at 11:58:59AM +0530, Manivannan Sadhasivam wrote:
> The LLCC EDAC register offsets varies between each SoC. Hardcoding the
> register offsets won't work and will often result in crash due to
> accessing the wrong locations.
>
> Hence, get the register offsets from the LLCC driver matching the
> individual SoCs.
>
> Cc: <stable@vger.kernel.org> # 6.0: 5365cea199c7 ("soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version")
> Cc: <stable@vger.kernel.org> # 6.0: c13d7d261e36 ("soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver")
> Cc: <stable@vger.kernel.org> # 6.0
> Fixes: a6e9d7ef252c ("soc: qcom: llcc: Add configuration data for SM8450 SoC")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/edac/qcom_edac.c | 116 ++++++++++++++---------------
> include/linux/soc/qcom/llcc-qcom.h | 6 --
> 2 files changed, 58 insertions(+), 64 deletions(-)
In case Bjorn wants to pick this up:
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-05-17 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 6:28 [RESEND PATCH v7 0/2] Fix crash when using Qcom LLCC/EDAC drivers Manivannan Sadhasivam
2023-05-17 6:28 ` [RESEND PATCH v7 1/2] EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup() Manivannan Sadhasivam
2023-05-17 10:35 ` Borislav Petkov
2023-05-17 6:28 ` [RESEND PATCH v7 2/2] EDAC/qcom: Get rid of hardcoded register offsets Manivannan Sadhasivam
2023-05-17 10:38 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517103815.GCZGSul9wCk4K8/XkN@fat_crate.local \
--to=bp@alien8.de \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=james.morse@arm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox