From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A721BC77B75 for ; Wed, 17 May 2023 19:12:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjEQTM2 (ORCPT ); Wed, 17 May 2023 15:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjEQTM0 (ORCPT ); Wed, 17 May 2023 15:12:26 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17039AD2A for ; Wed, 17 May 2023 12:12:13 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1ae54b623c2so9556205ad.3 for ; Wed, 17 May 2023 12:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684350732; x=1686942732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2TweVo7pe1RT0U4fJi1MmEd78Di3WvMfNoLR23I7nbs=; b=lbYAiBBRmL5JG7kvR3ch5RRhu+skJcHwpvcGTQun5EtQJEpcQC3jTxCTGQOM3dVW8X CrEjomYR2sZtOYw2xbyl9tOqhSYF/zT86dd11oD3tjkwXgF0T+QbRmX+4Bqihn7a/Yqh gkQW0IJ+k9LTKm7tT9O4BR/ogticSCt2HQ3+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684350732; x=1686942732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2TweVo7pe1RT0U4fJi1MmEd78Di3WvMfNoLR23I7nbs=; b=OKJWp1GuCxYFVFzvkGQ+amvu1kJ8KbepAbXttd8mEmCjuUVsR9Q6gofldwkvo45z4s Q+bVI4UUsh58NiooD1gMG1uubCvalSXXpJW5Bwdu2WGCGXEIFHdppOMvXqgLGSmjBpVW yCYIBNcaSvMq9p3x7RA1OlcSuDkXmqb5EU6O6dOYpo3D7th4qoohWcJU2TzVOBgatBbY 7JumWgSLoFLZ6tUUox9FqBBDCspfI4Q7UJvkZFVfEgJXJVf5fRdqv8HI/kb545qNKKRt PNHgK3eschTiK7LljBrlmUQf/1AsFznj8Vw+4QROOhOoupY4qG/rnqLT2nf0z+dKnAbw FUUg== X-Gm-Message-State: AC+VfDyj3gh8qo2lShHBHwkRPl1RxlbZWCJcQesppp9LskxudzLrzDZd 7Vwl/J5AzQ217e/u/C+2+6cbaQ== X-Google-Smtp-Source: ACHHUZ7YR5PTferdj6NHTPRa9xPJnCLNgUmoVpZYWgZwyj3/ZkalIoXAhIaQ+cJHTVYO73t+U3vEJg== X-Received: by 2002:a17:902:9a46:b0:1ae:5f7e:c117 with SMTP id x6-20020a1709029a4600b001ae5f7ec117mr1313241plv.60.1684350732651; Wed, 17 May 2023 12:12:12 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x21-20020a17090300d500b001a687c505e6sm18019526plc.232.2023.05.17.12.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 12:12:12 -0700 (PDT) Date: Wed, 17 May 2023 12:12:11 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 2/2][next] media: venus: hfi_cmds: Use struct_size() helper Message-ID: <202305171212.11465CFF3@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, May 16, 2023 at 05:14:49PM -0600, Gustavo A. R. Silva wrote: > Prefer struct_size() over open-coded versions of idiom: > > sizeof(struct-with-flex-array) + sizeof(typeof-flex-array-elements) * count > > where count is the max number of items the flexible array is supposed to > contain. > > Link: https://github.com/KSPP/linux/issues/160 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook