- * [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
@ 2023-05-19 18:07 ` Artur Weber
  2023-05-26 10:35   ` Daniel Thompson
  2023-06-08 15:46   ` Lee Jones
  2023-05-19 18:07 ` [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe Artur Weber
                   ` (4 subsequent siblings)
  5 siblings, 2 replies; 14+ messages in thread
From: Artur Weber @ 2023-05-19 18:07 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski
  Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Thierry Reding, Jonathan Hunter,
	Helge Deller, Uwe Kleine-König, Luca Weiss, Artur Weber,
	dri-devel, linux-leds, devicetree, linux-kernel, linux-arm-msm,
	linux-tegra, linux-fbdev, linux-pwm, ~postmarketos/upstreaming,
	Rob Herring
Notable changes:
- ROM child nodes use dashes instead of underscores; the driver
  reads all child nodes regardless of their names, so this doesn't
  break ABI.
- pwm-period argument is deprecated, as it effectively duplicates
  the period value provided in pwms. The driver continues to accept
  the property, so this should not break ABI.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changed in v2:
 - Added additionalProperties to ROM patternProperties
---
 .../leds/backlight/lp855x-backlight.yaml      | 149 ++++++++++++++++++
 .../bindings/leds/backlight/lp855x.txt        |  72 ---------
 2 files changed, 149 insertions(+), 72 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/lp855x-backlight.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/backlight/lp855x.txt
diff --git a/Documentation/devicetree/bindings/leds/backlight/lp855x-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lp855x-backlight.yaml
new file mode 100644
index 000000000000..9416e1bfab92
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/lp855x-backlight.yaml
@@ -0,0 +1,149 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/lp855x-backlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments LP855X backlight controllers
+
+maintainers:
+  - Artur Weber <aweber.kernel@gmail.com>
+
+properties:
+  compatible:
+    enum:
+      - ti,lp8550
+      - ti,lp8551
+      - ti,lp8552
+      - ti,lp8553
+      - ti,lp8555
+      - ti,lp8556
+      - ti,lp8557
+
+  reg:
+    maxItems: 1
+
+  dev-ctrl:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    description:
+      Value of device control register. This is a device-specific value.
+
+  bl-name:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: Backlight device name.
+
+  init-brt:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    description: Initial value of backlight brightness.
+
+  power-supply:
+    description: Regulator which controls the 3V rail.
+
+  enable-supply:
+    description: Regulator which controls the EN/VDDIO input.
+
+  pwms:
+    maxItems: 1
+    description: |
+      PWM channel to use for controlling the backlight; setting this
+      enables the PWM-based backlight control mode.
+
+  pwm-names: true
+
+  pwm-period:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      PWM period value. Deprecated; set the period value in the pwms
+      property instead.
+    deprecated: true
+
+patternProperties:
+  "^rom-[0-9a-f]{2}h$":
+    type: object
+    description: Nodes containing the values of configuration registers.
+    additionalProperties: false
+    properties:
+      rom-addr:
+        $ref: /schemas/types.yaml#/definitions/uint8
+        description: Register address of ROM area to be updated.
+
+      rom-val:
+        $ref: /schemas/types.yaml#/definitions/uint8
+        description: Value to write to the ROM register.
+
+required:
+  - compatible
+  - reg
+  - dev-ctrl
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        backlight@2c {
+            compatible = "ti,lp8555";
+            reg = <0x2c>;
+
+            dev-ctrl = /bits/ 8 <0x00>;
+
+            pwms = <&pwm 0 10000>;
+            pwm-names = "lp8555";
+
+            /* 4V OV, 4 output LED0 string enabled */
+            rom-14h {
+              rom-addr = /bits/ 8 <0x14>;
+              rom-val = /bits/ 8 <0xcf>;
+            };
+
+            /* Heavy smoothing, 24ms ramp time step */
+            rom-15h {
+              rom-addr = /bits/ 8 <0x15>;
+              rom-val = /bits/ 8 <0xc7>;
+            };
+
+            /* 4 output LED1 string enabled */
+            rom-19h {
+              rom-addr = /bits/ 8 <0x19>;
+              rom-val = /bits/ 8 <0x0f>;
+            };
+        };
+    };
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        backlight@2c {
+            compatible = "ti,lp8556";
+            reg = <0x2c>;
+
+            bl-name = "lcd-bl";
+            dev-ctrl = /bits/ 8 <0x85>;
+            init-brt = /bits/ 8 <0x10>;
+        };
+      };
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        backlight@2c {
+            compatible = "ti,lp8557";
+            reg = <0x2c>;
+            enable-supply = <&backlight_vddio>;
+            power-supply = <&backlight_vdd>;
+
+            dev-ctrl = /bits/ 8 <0x41>;
+            init-brt = /bits/ 8 <0x0a>;
+
+            /* 4V OV, 4 output LED string enabled */
+            rom-14h {
+              rom-addr = /bits/ 8 <0x14>;
+              rom-val = /bits/ 8 <0xcf>;
+            };
+        };
+    };
diff --git a/Documentation/devicetree/bindings/leds/backlight/lp855x.txt b/Documentation/devicetree/bindings/leds/backlight/lp855x.txt
deleted file mode 100644
index 88f56641fc28..000000000000
--- a/Documentation/devicetree/bindings/leds/backlight/lp855x.txt
+++ /dev/null
@@ -1,72 +0,0 @@
-lp855x bindings
-
-Required properties:
-  - compatible: "ti,lp8550", "ti,lp8551", "ti,lp8552", "ti,lp8553",
-                "ti,lp8555", "ti,lp8556", "ti,lp8557"
-  - reg: I2C slave address (u8)
-  - dev-ctrl: Value of DEVICE CONTROL register (u8). It depends on the device.
-
-Optional properties:
-  - bl-name: Backlight device name (string)
-  - init-brt: Initial value of backlight brightness (u8)
-  - pwm-period: PWM period value. Set only PWM input mode used (u32)
-  - rom-addr: Register address of ROM area to be updated (u8)
-  - rom-val: Register value to be updated (u8)
-  - power-supply: Regulator which controls the 3V rail
-  - enable-supply: Regulator which controls the EN/VDDIO input
-
-Example:
-
-	/* LP8555 */
-	backlight@2c {
-		compatible = "ti,lp8555";
-		reg = <0x2c>;
-
-		dev-ctrl = /bits/ 8 <0x00>;
-		pwm-period = <10000>;
-
-		/* 4V OV, 4 output LED0 string enabled */
-		rom_14h {
-			rom-addr = /bits/ 8 <0x14>;
-			rom-val = /bits/ 8 <0xcf>;
-		};
-
-		/* Heavy smoothing, 24ms ramp time step */
-		rom_15h {
-			rom-addr = /bits/ 8 <0x15>;
-			rom-val = /bits/ 8 <0xc7>;
-		};
-
-		/* 4 output LED1 string enabled */
-		rom_19h {
-			rom-addr = /bits/ 8 <0x19>;
-			rom-val = /bits/ 8 <0x0f>;
-		};
-	};
-
-	/* LP8556 */
-	backlight@2c {
-		compatible = "ti,lp8556";
-		reg = <0x2c>;
-
-		bl-name = "lcd-bl";
-		dev-ctrl = /bits/ 8 <0x85>;
-		init-brt = /bits/ 8 <0x10>;
-	};
-
-	/* LP8557 */
-	backlight@2c {
-		compatible = "ti,lp8557";
-		reg = <0x2c>;
-		enable-supply = <&backlight_vddio>;
-		power-supply = <&backlight_vdd>;
-
-		dev-ctrl = /bits/ 8 <0x41>;
-		init-brt = /bits/ 8 <0x0a>;
-
-		/* 4V OV, 4 output LED string enabled */
-		rom_14h {
-			rom-addr = /bits/ 8 <0x14>;
-			rom-val = /bits/ 8 <0xcf>;
-		};
-	};
-- 
2.40.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize
  2023-05-19 18:07 ` [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize Artur Weber
@ 2023-05-26 10:35   ` Daniel Thompson
  2023-06-08 15:46   ` Lee Jones
  1 sibling, 0 replies; 14+ messages in thread
From: Daniel Thompson @ 2023-05-26 10:35 UTC (permalink / raw)
  To: Artur Weber
  Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming, Rob Herring
On Fri, May 19, 2023 at 08:07:25PM +0200, Artur Weber wrote:
> Notable changes:
> - ROM child nodes use dashes instead of underscores; the driver
>   reads all child nodes regardless of their names, so this doesn't
>   break ABI.
> - pwm-period argument is deprecated, as it effectively duplicates
>   the period value provided in pwms. The driver continues to accept
>   the property, so this should not break ABI.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread 
- * Re: [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize
  2023-05-19 18:07 ` [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize Artur Weber
  2023-05-26 10:35   ` Daniel Thompson
@ 2023-06-08 15:46   ` Lee Jones
  1 sibling, 0 replies; 14+ messages in thread
From: Lee Jones @ 2023-06-08 15:46 UTC (permalink / raw)
  To: Artur Weber
  Cc: Rob Herring, Krzysztof Kozlowski, Daniel Thompson, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming, Rob Herring
On Fri, 19 May 2023, Artur Weber wrote:
> Notable changes:
> - ROM child nodes use dashes instead of underscores; the driver
>   reads all child nodes regardless of their names, so this doesn't
>   break ABI.
> - pwm-period argument is deprecated, as it effectively duplicates
>   the period value provided in pwms. The driver continues to accept
>   the property, so this should not break ABI.
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changed in v2:
>  - Added additionalProperties to ROM patternProperties
> ---
>  .../leds/backlight/lp855x-backlight.yaml      | 149 ++++++++++++++++++
>  .../bindings/leds/backlight/lp855x.txt        |  72 ---------
>  2 files changed, 149 insertions(+), 72 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/lp855x-backlight.yaml
>  delete mode 100644 Documentation/devicetree/bindings/leds/backlight/lp855x.txt
Applied, thanks
-- 
Lee Jones [李琼斯]
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
  2023-05-19 18:07 ` [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize Artur Weber
@ 2023-05-19 18:07 ` Artur Weber
  2023-05-26 10:38   ` Daniel Thompson
  2023-06-08 15:50   ` Lee Jones
  2023-05-19 18:07 ` [PATCH v2 3/4] ARM: dts: adapt to LP855X bindings changes Artur Weber
                   ` (3 subsequent siblings)
  5 siblings, 2 replies; 14+ messages in thread
From: Artur Weber @ 2023-05-19 18:07 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski
  Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Thierry Reding, Jonathan Hunter,
	Helge Deller, Uwe Kleine-König, Luca Weiss, Artur Weber,
	dri-devel, linux-leds, devicetree, linux-kernel, linux-arm-msm,
	linux-tegra, linux-fbdev, linux-pwm, ~postmarketos/upstreaming
Also deprecate the pwm-period DT property, as it is now redundant
(pwms property already contains period value).
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
 drivers/video/backlight/lp855x_bl.c | 48 ++++++++++++++++-------------
 1 file changed, 26 insertions(+), 22 deletions(-)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a57c9ef3b1cc..0ef850dd8e84 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -218,23 +218,10 @@ static int lp855x_configure(struct lp855x *lp)
 
 static void lp855x_pwm_ctrl(struct lp855x *lp, int br, int max_br)
 {
-	struct pwm_device *pwm;
 	struct pwm_state state;
 
-	/* request pwm device with the consumer name */
-	if (!lp->pwm) {
-		pwm = devm_pwm_get(lp->dev, lp->chipname);
-		if (IS_ERR(pwm))
-			return;
-
-		lp->pwm = pwm;
-
-		pwm_init_state(lp->pwm, &state);
-	} else {
-		pwm_get_state(lp->pwm, &state);
-	}
+	pwm_get_state(lp->pwm, &state);
 
-	state.period = lp->pdata->period_ns;
 	state.duty_cycle = div_u64(br * state.period, max_br);
 	state.enabled = state.duty_cycle;
 
@@ -339,6 +326,7 @@ static int lp855x_parse_dt(struct lp855x *lp)
 	of_property_read_string(node, "bl-name", &pdata->name);
 	of_property_read_u8(node, "dev-ctrl", &pdata->device_control);
 	of_property_read_u8(node, "init-brt", &pdata->initial_brightness);
+	/* Deprecated, specify period in pwms property instead */
 	of_property_read_u32(node, "pwm-period", &pdata->period_ns);
 
 	/* Fill ROM platform data if defined */
@@ -399,6 +387,7 @@ static int lp855x_probe(struct i2c_client *cl)
 	const struct i2c_device_id *id = i2c_client_get_device_id(cl);
 	const struct acpi_device_id *acpi_id = NULL;
 	struct device *dev = &cl->dev;
+	struct pwm_state pwmstate;
 	struct lp855x *lp;
 	int ret;
 
@@ -457,11 +446,6 @@ static int lp855x_probe(struct i2c_client *cl)
 		}
 	}
 
-	if (lp->pdata->period_ns > 0)
-		lp->mode = PWM_BASED;
-	else
-		lp->mode = REGISTER_BASED;
-
 	lp->supply = devm_regulator_get(dev, "power");
 	if (IS_ERR(lp->supply)) {
 		if (PTR_ERR(lp->supply) == -EPROBE_DEFER)
@@ -472,11 +456,31 @@ static int lp855x_probe(struct i2c_client *cl)
 	lp->enable = devm_regulator_get_optional(dev, "enable");
 	if (IS_ERR(lp->enable)) {
 		ret = PTR_ERR(lp->enable);
-		if (ret == -ENODEV) {
+		if (ret == -ENODEV)
 			lp->enable = NULL;
-		} else {
+		else
 			return dev_err_probe(dev, ret, "getting enable regulator\n");
-		}
+	}
+
+	lp->pwm = devm_pwm_get(lp->dev, lp->chipname);
+	if (IS_ERR(lp->pwm)) {
+		ret = PTR_ERR(lp->pwm);
+		if (ret == -ENODEV || ret == -EINVAL)
+			lp->pwm = NULL;
+		else
+			return dev_err_probe(dev, ret, "getting PWM\n");
+
+		lp->mode = REGISTER_BASED;
+		dev_dbg(dev, "mode: register based\n");
+	} else {
+		pwm_init_state(lp->pwm, &pwmstate);
+		/* Legacy platform data compatibility */
+		if (lp->pdata->period_ns > 0)
+			pwmstate.period = lp->pdata->period_ns;
+		pwm_apply_state(lp->pwm, &pwmstate);
+
+		lp->mode = PWM_BASED;
+		dev_dbg(dev, "mode: PWM based\n");
 	}
 
 	if (lp->supply) {
-- 
2.40.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe
  2023-05-19 18:07 ` [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe Artur Weber
@ 2023-05-26 10:38   ` Daniel Thompson
  2023-06-08 15:50   ` Lee Jones
  1 sibling, 0 replies; 14+ messages in thread
From: Daniel Thompson @ 2023-05-26 10:38 UTC (permalink / raw)
  To: Artur Weber
  Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming
On Fri, May 19, 2023 at 08:07:26PM +0200, Artur Weber wrote:
> Also deprecate the pwm-period DT property, as it is now redundant
> (pwms property already contains period value).
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread 
- * Re: [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe
  2023-05-19 18:07 ` [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe Artur Weber
  2023-05-26 10:38   ` Daniel Thompson
@ 2023-06-08 15:50   ` Lee Jones
  1 sibling, 0 replies; 14+ messages in thread
From: Lee Jones @ 2023-06-08 15:50 UTC (permalink / raw)
  To: Artur Weber
  Cc: Rob Herring, Krzysztof Kozlowski, Daniel Thompson, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming
On Fri, 19 May 2023, Artur Weber wrote:
> Also deprecate the pwm-period DT property, as it is now redundant
> (pwms property already contains period value).
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
>  drivers/video/backlight/lp855x_bl.c | 48 ++++++++++++++++-------------
>  1 file changed, 26 insertions(+), 22 deletions(-)
Applied, thanks
-- 
Lee Jones [李琼斯]
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * [PATCH v2 3/4] ARM: dts: adapt to LP855X bindings changes
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
  2023-05-19 18:07 ` [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize Artur Weber
  2023-05-19 18:07 ` [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe Artur Weber
@ 2023-05-19 18:07 ` Artur Weber
  2023-05-26 10:39   ` Daniel Thompson
  2023-05-19 18:07 ` [PATCH v2 4/4] arm64: " Artur Weber
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Artur Weber @ 2023-05-19 18:07 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski
  Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Thierry Reding, Jonathan Hunter,
	Helge Deller, Uwe Kleine-König, Luca Weiss, Artur Weber,
	dri-devel, linux-leds, devicetree, linux-kernel, linux-arm-msm,
	linux-tegra, linux-fbdev, linux-pwm, ~postmarketos/upstreaming
Change underscores in ROM node names to dashes, and remove deprecated
pwm-period property.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
---
 .../dts/qcom-apq8026-samsung-matisse-wifi.dts |  1 -
 ...-msm8974pro-sony-xperia-shinano-castor.dts | 23 ++++++++++---------
 2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
index 91b860e24681..884d99297d4c 100644
--- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
@@ -99,7 +99,6 @@ backlight@2c {
 
 			dev-ctrl = /bits/ 8 <0x80>;
 			init-brt = /bits/ 8 <0x3f>;
-			pwm-period = <100000>;
 
 			pwms = <&backlight_pwm 0 100000>;
 			pwm-names = "lp8556";
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 04bc58d87abf..2396253f953a 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -150,47 +150,48 @@ lp8566_wled: backlight@2c {
 		bl-name = "backlight";
 		dev-ctrl = /bits/ 8 <0x05>;
 		init-brt = /bits/ 8 <0x3f>;
-		rom_a0h {
+
+		rom-a0h {
 			rom-addr = /bits/ 8 <0xa0>;
 			rom-val = /bits/ 8 <0xff>;
 		};
-		rom_a1h {
+		rom-a1h {
 			rom-addr = /bits/ 8 <0xa1>;
 			rom-val = /bits/ 8 <0x3f>;
 		};
-		rom_a2h {
+		rom-a2h {
 			rom-addr = /bits/ 8 <0xa2>;
 			rom-val = /bits/ 8 <0x20>;
 		};
-		rom_a3h {
+		rom-a3h {
 			rom-addr = /bits/ 8 <0xa3>;
 			rom-val = /bits/ 8 <0x5e>;
 		};
-		rom_a4h {
+		rom-a4h {
 			rom-addr = /bits/ 8 <0xa4>;
 			rom-val = /bits/ 8 <0x02>;
 		};
-		rom_a5h {
+		rom-a5h {
 			rom-addr = /bits/ 8 <0xa5>;
 			rom-val = /bits/ 8 <0x04>;
 		};
-		rom_a6h {
+		rom-a6h {
 			rom-addr = /bits/ 8 <0xa6>;
 			rom-val = /bits/ 8 <0x80>;
 		};
-		rom_a7h {
+		rom-a7h {
 			rom-addr = /bits/ 8 <0xa7>;
 			rom-val = /bits/ 8 <0xf7>;
 		};
-		rom_a9h {
+		rom-a9h {
 			rom-addr = /bits/ 8 <0xa9>;
 			rom-val = /bits/ 8 <0x80>;
 		};
-		rom_aah {
+		rom-aah {
 			rom-addr = /bits/ 8 <0xaa>;
 			rom-val = /bits/ 8 <0x0f>;
 		};
-		rom_aeh {
+		rom-aeh {
 			rom-addr = /bits/ 8 <0xae>;
 			rom-val = /bits/ 8 <0x0f>;
 		};
-- 
2.40.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH v2 3/4] ARM: dts: adapt to LP855X bindings changes
  2023-05-19 18:07 ` [PATCH v2 3/4] ARM: dts: adapt to LP855X bindings changes Artur Weber
@ 2023-05-26 10:39   ` Daniel Thompson
  0 siblings, 0 replies; 14+ messages in thread
From: Daniel Thompson @ 2023-05-26 10:39 UTC (permalink / raw)
  To: Artur Weber
  Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming
On Fri, May 19, 2023 at 08:07:27PM +0200, Artur Weber wrote:
> Change underscores in ROM node names to dashes, and remove deprecated
> pwm-period property.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * [PATCH v2 4/4] arm64: dts: adapt to LP855X bindings changes
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
                   ` (2 preceding siblings ...)
  2023-05-19 18:07 ` [PATCH v2 3/4] ARM: dts: adapt to LP855X bindings changes Artur Weber
@ 2023-05-19 18:07 ` Artur Weber
  2023-05-26 10:39   ` Daniel Thompson
  2023-06-13 22:30 ` (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Bjorn Andersson
  2023-07-21 15:33 ` Thierry Reding
  5 siblings, 1 reply; 14+ messages in thread
From: Artur Weber @ 2023-05-19 18:07 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski
  Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Thierry Reding, Jonathan Hunter,
	Helge Deller, Uwe Kleine-König, Luca Weiss, Artur Weber,
	dri-devel, linux-leds, devicetree, linux-kernel, linux-arm-msm,
	linux-tegra, linux-fbdev, linux-pwm, ~postmarketos/upstreaming
Change underscores in ROM node names to dashes, and remove deprecated
pwm-period property.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
index 38f4ff229bef..a6a58e51822d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts
@@ -58,19 +58,17 @@ backlight: backlight@2c {
 			dev-ctrl = /bits/ 8 <0x80>;
 			init-brt = /bits/ 8 <0xff>;
 
-			pwm-period = <29334>;
-
 			pwms = <&pwm 0 29334>;
 			pwm-names = "lp8557";
 
 			/* boost frequency 1 MHz */
-			rom_13h {
+			rom-13h {
 				rom-addr = /bits/ 8 <0x13>;
 				rom-val = /bits/ 8 <0x01>;
 			};
 
 			/* 3 LED string */
-			rom_14h {
+			rom-14h {
 				rom-addr = /bits/ 8 <0x14>;
 				rom-val = /bits/ 8 <0x87>;
 			};
-- 
2.40.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH v2 4/4] arm64: dts: adapt to LP855X bindings changes
  2023-05-19 18:07 ` [PATCH v2 4/4] arm64: " Artur Weber
@ 2023-05-26 10:39   ` Daniel Thompson
  0 siblings, 0 replies; 14+ messages in thread
From: Daniel Thompson @ 2023-05-26 10:39 UTC (permalink / raw)
  To: Artur Weber
  Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Jingoo Han,
	Pavel Machek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Thierry Reding, Jonathan Hunter, Helge Deller,
	Uwe Kleine-König, Luca Weiss, dri-devel, linux-leds,
	devicetree, linux-kernel, linux-arm-msm, linux-tegra, linux-fbdev,
	linux-pwm, ~postmarketos/upstreaming
On Fri, May 19, 2023 at 08:07:28PM +0200, Artur Weber wrote:
> Change underscores in ROM node names to dashes, and remove deprecated
> pwm-period property.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
                   ` (3 preceding siblings ...)
  2023-05-19 18:07 ` [PATCH v2 4/4] arm64: " Artur Weber
@ 2023-06-13 22:30 ` Bjorn Andersson
  2023-06-15 16:41   ` Bjorn Andersson
  2023-07-21 15:33 ` Thierry Reding
  5 siblings, 1 reply; 14+ messages in thread
From: Bjorn Andersson @ 2023-06-13 22:30 UTC (permalink / raw)
  To: Artur Weber, Lee Jones, Krzysztof Kozlowski, Rob Herring
  Cc: Jingoo Han, linux-tegra, Jonathan Hunter, linux-arm-msm,
	linux-fbdev, dri-devel, linux-pwm, ~postmarketos/upstreaming,
	linux-leds, Thierry Reding, Daniel Thompson, Konrad Dybcio,
	Pavel Machek, Uwe Kleine-König, Helge Deller, linux-kernel,
	Luca Weiss, Andy Gross, devicetree
On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote:
> Convert TI LP855X backlight controller bindings from TXT to YAML and,
> while we're at it, rework some of the code related to PWM handling.
> Also correct existing DTS files to avoid introducing new dtb_check
> errors.
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> 
> [...]
Applied, thanks!
[4/4] arm64: dts: adapt to LP855X bindings changes
      commit: ebdcfc8c42c2b9d5ca1b27d8ee558eefb3e904d8
Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings
  2023-06-13 22:30 ` (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Bjorn Andersson
@ 2023-06-15 16:41   ` Bjorn Andersson
  0 siblings, 0 replies; 14+ messages in thread
From: Bjorn Andersson @ 2023-06-15 16:41 UTC (permalink / raw)
  To: Artur Weber, Lee Jones, Krzysztof Kozlowski, Rob Herring
  Cc: Jingoo Han, linux-tegra, Jonathan Hunter, linux-arm-msm,
	linux-fbdev, dri-devel, linux-pwm, ~postmarketos/upstreaming,
	linux-leds, Thierry Reding, Daniel Thompson, Konrad Dybcio,
	Pavel Machek, Uwe Kleine-König, Helge Deller, linux-kernel,
	Luca Weiss, Andy Gross, devicetree
On Tue, Jun 13, 2023 at 03:30:10PM -0700, Bjorn Andersson wrote:
> On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote:
> > Convert TI LP855X backlight controller bindings from TXT to YAML and,
> > while we're at it, rework some of the code related to PWM handling.
> > Also correct existing DTS files to avoid introducing new dtb_check
> > errors.
> > 
> > Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> > 
> > [...]
> 
> Applied, thanks!
> 
> [4/4] arm64: dts: adapt to LP855X bindings changes
>       commit: ebdcfc8c42c2b9d5ca1b27d8ee558eefb3e904d8
> 
Sorry, that was not for me to pick up. So I've dropped this change
again.
Please note that all other changes to the affected file is prefixed
"arm64: tegra:". Following this is a good idea, and would have helped me
not accidentally pick this change.
Regards,
Bjorn
> Best regards,
> -- 
> Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings
  2023-05-19 18:07 [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Artur Weber
                   ` (4 preceding siblings ...)
  2023-06-13 22:30 ` (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings Bjorn Andersson
@ 2023-07-21 15:33 ` Thierry Reding
  5 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2023-07-21 15:33 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Artur Weber
  Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Thierry Reding, Jonathan Hunter,
	Helge Deller, Uwe Kleine-König, Luca Weiss, dri-devel,
	linux-leds, devicetree, linux-kernel, linux-arm-msm, linux-tegra,
	linux-fbdev, linux-pwm, ~postmarketos/upstreaming
From: Thierry Reding <treding@nvidia.com>
On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote:
> Convert TI LP855X backlight controller bindings from TXT to YAML and,
> while we're at it, rework some of the code related to PWM handling.
> Also correct existing DTS files to avoid introducing new dtb_check
> errors.
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> 
> [...]
Applied, thanks!
[4/4] arm64: dts: adapt to LP855X bindings changes
      commit: faae0778fa10fa4e8909fe9164f06acab170f1e9
Best regards,
-- 
Thierry Reding <treding@nvidia.com>
^ permalink raw reply	[flat|nested] 14+ messages in thread