[PATCH 0/2] mfd: pm8008: fix module autoloading

[PATCH 0/2] mfd: pm8008: fix module autoloading

[Johan Hovold]

This series adds the missing module device table alias needed for module
autoloading to the pm8008 driver and drops a bogus i2c module alias
which has never been used.

Johan


Johan Hovold (2):
  mfd: pm8008: fix module autoloading
  mfd: pm8008: drop bogus i2c module alias

 drivers/mfd/qcom-pm8008.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.39.3

[PATCH 1/2] mfd: pm8008: fix module autoloading

[Johan Hovold]

Add the missing module device table alias to that the driver can be
autoloaded when built as a module.

Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Cc: stable@vger.kernel.org      # 5.14
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/mfd/qcom-pm8008.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index 837246aab4ac..29ec3901564b 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
 	{ .compatible = "qcom,pm8008", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, pm8008_match);
 
 static struct i2c_driver pm8008_mfd_driver = {
 	.driver = {
-- 
2.39.3

[PATCH 2/2] mfd: pm8008: drop bogus i2c module alias

[Johan Hovold]

Prior to commit af503716ac14 ("i2c: core: report OF style module alias
for devices registered via OF") drivers using OF matching needed an i2c
module alias such as "i2c:pm8008" for module autoloading to work.

Drop the bogus i2c alias from the pm8008 driver which was merged long
after i2c core was fixed and whose alias did not match the driver name
("pm8008") to begin with.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/mfd/qcom-pm8008.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index 29ec3901564b..c4cef3936ea3 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -211,4 +211,3 @@ static struct i2c_driver pm8008_mfd_driver = {
 module_i2c_driver(pm8008_mfd_driver);
 
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("i2c:qcom-pm8008");
-- 
2.39.3

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Konrad Dybcio]

On 26.05.2023 11:16, Johan Hovold wrote:
> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
5.13 would be more fitting here?

Konrad
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index 837246aab4ac..29ec3901564b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
>  	{ .compatible = "qcom,pm8008", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match);
>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Johan Hovold]

On Fri, May 26, 2023 at 11:22:27AM +0200, Konrad Dybcio wrote:
> On 26.05.2023 11:16, Johan Hovold wrote:
> > Add the missing module device table alias to that the driver can be
> > autoloaded when built as a module.
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Cc: stable@vger.kernel.org      # 5.14

> Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
> 5.13 would be more fitting here?

No, I just double checked. This driver was not present 5.13.

Johan

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Konrad Dybcio]

On 26.05.2023 11:25, Johan Hovold wrote:
> On Fri, May 26, 2023 at 11:22:27AM +0200, Konrad Dybcio wrote:
>> On 26.05.2023 11:16, Johan Hovold wrote:
>>> Add the missing module device table alias to that the driver can be
>>> autoloaded when built as a module.
>>>
>>> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
>>> Cc: stable@vger.kernel.org      # 5.14
> 
>> Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
>> 5.13 would be more fitting here?
> 
> No, I just double checked. This driver was not present 5.13.
Odd, I see the same thing.

Anyway

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Johan

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Lee Jones]

On Fri, 26 May 2023, Johan Hovold wrote:

> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

-- 
Lee Jones [李琼斯]

Re: [PATCH 2/2] mfd: pm8008: drop bogus i2c module alias

[Lee Jones]

On Fri, 26 May 2023, Johan Hovold wrote:

> Prior to commit af503716ac14 ("i2c: core: report OF style module alias
> for devices registered via OF") drivers using OF matching needed an i2c
> module alias such as "i2c:pm8008" for module autoloading to work.
> 
> Drop the bogus i2c alias from the pm8008 driver which was merged long
> after i2c core was fixed and whose alias did not match the driver name
> ("pm8008") to begin with.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Johan Hovold]

On Thu, Jun 08, 2023 at 04:45:03PM +0100, Lee Jones wrote:
> On Fri, 26 May 2023, Johan Hovold wrote:
> 
> > Add the missing module device table alias to that the driver can be
> > autoloaded when built as a module.
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Cc: stable@vger.kernel.org      # 5.14
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  drivers/mfd/qcom-pm8008.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Applied, thanks

Thanks, Lee. Did you forget to push these out? I was gonna see if you
merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
repo.

Johan

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Lee Jones]

On Fri, 09 Jun 2023, Johan Hovold wrote:

> On Thu, Jun 08, 2023 at 04:45:03PM +0100, Lee Jones wrote:
> > On Fri, 26 May 2023, Johan Hovold wrote:
> > 
> > > Add the missing module device table alias to that the driver can be
> > > autoloaded when built as a module.
> > > 
> > > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > > Cc: stable@vger.kernel.org      # 5.14
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> > >  drivers/mfd/qcom-pm8008.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Applied, thanks
> 
> Thanks, Lee. Did you forget to push these out? I was gonna see if you
> merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
> repo.

I don't tend to push daily.  I can push them now if you like.

These were added for v6.5.

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: pm8008: fix module autoloading

[Johan Hovold]

On Fri, Jun 09, 2023 at 07:38:04AM +0100, Lee Jones wrote:
> On Fri, 09 Jun 2023, Johan Hovold wrote:

> > Thanks, Lee. Did you forget to push these out? I was gonna see if you
> > merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
> > repo.
> 
> I don't tend to push daily.  I can push them now if you like.
> 
> These were added for v6.5.

Perfect, thanks!

Johan