From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 652C0C7EE25 for ; Thu, 8 Jun 2023 09:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234955AbjFHJU1 (ORCPT ); Thu, 8 Jun 2023 05:20:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232272AbjFHJU0 (ORCPT ); Thu, 8 Jun 2023 05:20:26 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ACF718F; Thu, 8 Jun 2023 02:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686216025; x=1717752025; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ImvKob1XLuKksnBkKdSIUMhiZFOJa0LRyXm3owOpFFY=; b=wSerHhqUUwjM2WcctY2xGwEUuasUaqJf95a+HKK7r8y4TpObR+lVuqMs auFPKlYHj4gaf+YDTFKVu/axF2hoZDRerFjMuLVBZ2hAPlEOO2lUbIh2g BtK6GLme3CBJduKIIzLF2T32us/4U+HXLjyG+DJb9y5ruzu/NkvGDOHcf RbPNfsHCwK/ZSznmirYTsJm4NJbfe5pQFhQ0fOTeGJOW7hkrUcNynw5Ve i05UYidO8ZX6zU6spc/0ILzgqT3Fmcj2Lnp8NXBYurUsYI3jg8lbljNF5 Uvu9LteoHzzqR5Z164W2nizvXBz25i1s99wOtigWsx7g/SMV9f/bUODV9 g==; X-IronPort-AV: E=Sophos;i="6.00,226,1681196400"; d="asc'?scan'208";a="216828071" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Jun 2023 02:20:24 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 8 Jun 2023 02:20:24 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 8 Jun 2023 02:20:22 -0700 Date: Thu, 8 Jun 2023 10:19:58 +0100 From: Conor Dooley To: Tushar Nimkar CC: "Rafael J . Wysocki" , Daniel Lezcano , Ulf Hansson , , , , , , Subject: Re: [PATCH 1/2] dt-bindings: arm: idle-states: Add idle-state-disabled property Message-ID: <20230608-steadying-idealism-1f8a97db1491@wendy> References: <20230608085544.16211-1-quic_tnimkar@quicinc.com> <20230608085544.16211-2-quic_tnimkar@quicinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vtCTEnlvLCD5pXov" Content-Disposition: inline In-Reply-To: <20230608085544.16211-2-quic_tnimkar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --vtCTEnlvLCD5pXov Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Tushar, On Thu, Jun 08, 2023 at 02:25:42PM +0530, Tushar Nimkar wrote: > This change adds idle-state-disabled property using which certain or all > idle-states can be kept disabled during boot-up. Once boot-up is completed > same can be enabled using below command. >=20 > echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable >=20 > Cc: devicetree@vger.kernel.org Firstly, you should CC the dt-bindings maintainers like get_maintainer.pl would tell you. Secondly, there are two 1/2 patches in this series. > Signed-off-by: Tushar Nimkar > --- > Documentation/devicetree/bindings/cpu/idle-states.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/cpu/idle-states.yaml b/Doc= umentation/devicetree/bindings/cpu/idle-states.yaml > index b8cc826c9501..f999bc666bbd 100644 > --- a/Documentation/devicetree/bindings/cpu/idle-states.yaml > +++ b/Documentation/devicetree/bindings/cpu/idle-states.yaml > @@ -358,6 +358,13 @@ patternProperties: > systems entry-latency-us + exit-latency-us will exceed > wakeup-latency-us by this duration. > =20 > + idle-state-disabled: > + description: | > + If present the idle state stays disabled. > It can be enabled back from > + shell using below command. > + echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable Thirdly, this is operating system specific behaviour, tied to Linux, and has no place in a binding. Cheers, Conor. > + type: boolean > + > idle-state-name: > $ref: /schemas/types.yaml#/definitions/string > description: > @@ -548,6 +555,7 @@ examples: > CPU_SLEEP_0_0: cpu-sleep-0-0 { > compatible =3D "arm,idle-state"; > local-timer-stop; > + idle-state-disabled; > arm,psci-suspend-param =3D <0x0010000>; > entry-latency-us =3D <250>; > exit-latency-us =3D <500>; > --=20 > 2.17.1 >=20 --vtCTEnlvLCD5pXov Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIGdPgAKCRB4tDGHoIJi 0jYeAQD2vq8CAZyZPfQBYO0XGcZgS5CZfIokwYmVJvMluNX5FgD/VKSusjjBHh15 cAJDaI7n/Zxpka9ImfjHO1sN2deJHgs= =tiyx -----END PGP SIGNATURE----- --vtCTEnlvLCD5pXov--