From: Manivannan Sadhasivam <mani@kernel.org>
To: "Duke Xin(辛安文)" <duke_xinanwen@163.com>
Cc: loic.poulain@linaro.org, slark_xiao@163.com,
fabio.porcedda@gmail.com, koen.vandeputte@citymesh.com,
song.fc@gmail.com, bhelgaas@google.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, jerry.meng@quectel.com,
duke.xin@quectel.com
Subject: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
Date: Thu, 8 Jun 2023 21:35:30 +0530 [thread overview]
Message-ID: <20230608160530.GC8632@thinkpad> (raw)
In-Reply-To: <20230608092927.2893-1-duke_xinanwen@163.com>
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
EM160R-GL is exactly the same name as the old modem with same chipset. What is
the difference between these two?
- Mani
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-06-08 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 9:29 [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product Duke Xin(辛安文)
2023-06-08 16:05 ` Manivannan Sadhasivam [this message]
2023-06-09 1:21 ` 回复: " Duke Xin(辛安文)
2023-06-09 15:32 ` Manivannan Sadhasivam
2023-06-09 15:38 ` Manivannan Sadhasivam
2023-06-12 2:02 ` 回复: " Duke Xin(辛安文)
2023-06-21 10:36 ` Duke Xin(辛安文)
2023-06-24 6:57 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608160530.GC8632@thinkpad \
--to=mani@kernel.org \
--cc=bhelgaas@google.com \
--cc=duke.xin@quectel.com \
--cc=duke_xinanwen@163.com \
--cc=fabio.porcedda@gmail.com \
--cc=jerry.meng@quectel.com \
--cc=koen.vandeputte@citymesh.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
--cc=song.fc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox