* [PATCH] serial: qcom-geni: use icc tag defines
@ 2023-07-11 16:05 Johan Hovold
2023-07-11 17:00 ` Georgi Djakov
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2023-07-11 16:05 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Jiri Slaby,
linux-arm-msm, linux-serial, linux-kernel, Johan Hovold
Use the Qualcomm interconnect defines rather than magic numbers for the
icc tags also in the restore() PM callback.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/tty/serial/qcom_geni_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 444c74eeab7d..88ed5bbe25a8 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1757,7 +1757,7 @@ static int qcom_geni_serial_sys_hib_resume(struct device *dev)
private_data = uport->private_data;
if (uart_console(uport)) {
- geni_icc_set_tag(&port->se, 0x7);
+ geni_icc_set_tag(&port->se, QCOM_ICC_TAG_ALWAYS);
geni_icc_set_bw(&port->se);
ret = uart_resume_port(private_data->drv, uport);
/*
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial: qcom-geni: use icc tag defines
2023-07-11 16:05 [PATCH] serial: qcom-geni: use icc tag defines Johan Hovold
@ 2023-07-11 17:00 ` Georgi Djakov
0 siblings, 0 replies; 2+ messages in thread
From: Georgi Djakov @ 2023-07-11 17:00 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Jiri Slaby,
linux-arm-msm, linux-serial, linux-kernel
On 11.07.23 19:05, Johan Hovold wrote:
> Use the Qualcomm interconnect defines rather than magic numbers for the
> icc tags also in the restore() PM callback.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Georgi Djakov <djakov@kernel.org>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 444c74eeab7d..88ed5bbe25a8 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1757,7 +1757,7 @@ static int qcom_geni_serial_sys_hib_resume(struct device *dev)
> private_data = uport->private_data;
>
> if (uart_console(uport)) {
> - geni_icc_set_tag(&port->se, 0x7);
> + geni_icc_set_tag(&port->se, QCOM_ICC_TAG_ALWAYS);
> geni_icc_set_bw(&port->se);
> ret = uart_resume_port(private_data->drv, uport);
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-11 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 16:05 [PATCH] serial: qcom-geni: use icc tag defines Johan Hovold
2023-07-11 17:00 ` Georgi Djakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).