* [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
@ 2023-07-12 7:52 Luca Weiss
2023-07-15 14:08 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Luca Weiss @ 2023-07-12 7:52 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss
Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
should provide them in the dt, which I missed in the commit adding the
mdss nodes.
Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
index b6ae4b7936e3..d2d09f2f3cee 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
@@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
<&gcc GPLL0_VOTE>,
<&gcc GPLL1_VOTE>,
<&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
- <0>,
- <0>;
+ <&mdss_dsi0_phy 1>,
+ <&mdss_dsi0_phy 0>;
clock-names = "xo",
"mmss_gpll0_vote",
"gpll0_vote",
---
base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9
Best regards,
--
Luca Weiss <luca@z3ntu.xyz>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
2023-07-12 7:52 [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc Luca Weiss
@ 2023-07-15 14:08 ` Konrad Dybcio
2023-09-22 16:57 ` Luca Weiss
2023-09-23 19:40 ` Dmitry Baryshkov
2023-10-22 15:50 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-07-15 14:08 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 12.07.2023 09:52, Luca Weiss wrote:
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
> Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> index b6ae4b7936e3..d2d09f2f3cee 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> @@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
> <&gcc GPLL0_VOTE>,
> <&gcc GPLL1_VOTE>,
> <&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
> - <0>,
> - <0>;
> + <&mdss_dsi0_phy 1>,
> + <&mdss_dsi0_phy 0>;
> clock-names = "xo",
> "mmss_gpll0_vote",
> "gpll0_vote",
>
> ---
> base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
> change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
2023-07-15 14:08 ` Konrad Dybcio
@ 2023-09-22 16:57 ` Luca Weiss
0 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2023-09-22 16:57 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On Samstag, 15. Juli 2023 16:08:37 CEST Konrad Dybcio wrote:
> On 12.07.2023 09:52, Luca Weiss wrote:
> > Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> > should provide them in the dt, which I missed in the commit adding the
> > mdss nodes.
> >
> > Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad
Hi Bjorn,
this patch is still waiting to be picked up :) Would be nice to get it into
v6.7.
Regards
Luca
>
> > arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi index
> > b6ae4b7936e3..d2d09f2f3cee 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > @@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
> >
> > <&gcc GPLL0_VOTE>,
> > <&gcc GPLL1_VOTE>,
> > <&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
> >
> > - <0>,
> > - <0>;
> > + <&mdss_dsi0_phy 1>,
> > + <&mdss_dsi0_phy 0>;
> >
> > clock-names = "xo",
> >
> > "mmss_gpll0_vote",
> > "gpll0_vote",
> >
> > ---
> > base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
> > change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9
> >
> > Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
2023-07-12 7:52 [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc Luca Weiss
2023-07-15 14:08 ` Konrad Dybcio
@ 2023-09-23 19:40 ` Dmitry Baryshkov
2023-10-22 15:50 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-09-23 19:40 UTC (permalink / raw)
To: Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, 12 Jul 2023 at 10:53, Luca Weiss <luca@z3ntu.xyz> wrote:
>
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
> Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
2023-07-12 7:52 [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc Luca Weiss
2023-07-15 14:08 ` Konrad Dybcio
2023-09-23 19:40 ` Dmitry Baryshkov
@ 2023-10-22 15:50 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-10-22 15:50 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss
Cc: linux-arm-msm, devicetree, linux-kernel
On Wed, 12 Jul 2023 09:52:07 +0200, Luca Weiss wrote:
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
commit: 836d083524888069cd358776a4e6c4ceec04962e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-22 16:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 7:52 [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc Luca Weiss
2023-07-15 14:08 ` Konrad Dybcio
2023-09-22 16:57 ` Luca Weiss
2023-09-23 19:40 ` Dmitry Baryshkov
2023-10-22 15:50 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).