Re: [PATCH] bus: mhi: host: pci_generic: Add support for Dell DW5932e

Manivannan Sadhasivam
2023-07-12T12:24:21Z

On Wed, Jul 12, 2023 at 04:37:41PM +0800, Slark Xiao wrote:
> The DW5932e has 2 variants: eSIM(DW5932e-eSIM) and non-eSIM(DW5932e).
> Both of them are designed based on Qualcomm SDX62 and it will
> align with the Foxconn sdx65 settings.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>

One nit below but I will fix that while applying.

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

> ---
> drivers/bus/mhi/host/pci_generic.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9ca0dc3a3bfe..07172789b197 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -625,6 +625,12 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> /* T99W510 (sdx24), variant 3 */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f2),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx24_info },
> + /* DW5932e-eSIM (sdx62), With eSIM */
> + { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f5),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info },
> + /* DW5932e (sdx62), Non-eSIM*/

Space required before */

- Mani

> + { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f9),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info },
> /* MV31-W (Cinterion) */
> { PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3),
> .driver_data = (kernel_ulong_t) &mhi_mv31_info },
> --
> 2.25.1
>

--
மணிவண்ணன் சதாசிவம்