Re: [PATCH V2] net: mhi : Add support to enable ethernet interface

Manivannan Sadhasivam
2023-07-19T11:42:26Z

On Wed, Jul 19, 2023 at 04:08:37PM +0530, Vivek Pernamitta wrote:
>
> Currently MHI NET driver does not support Ethernet interface,
>

Please do not top post. Read: https://people.kernel.org/tglx/notes-about-netiquette-qw89

> we are adding Ethernet interface support to MHI NET driver, so new client
> can be configured to be Ethernet type over MHI by setting
> "mhi_device_info.ethernet_if = true"
>

Which is the new client you are referring to?

> currently we are not changing mhi_swip0/mhi_hwip0 to Ethernet. we are adding
> an provision to configure mhi client as  Ethernet type.
>

If there are no users of the said provision, then it should not be added now.
You can only add interfaces to kernel if there is atleast one user.

- Mani

>
> On 7/18/2023 6:13 PM, Manivannan Sadhasivam wrote:
> > On Tue, Jul 18, 2023 at 11:45:28AM +0530, Vivek Pernamitta wrote:
> > > Add support to enable ethernet interface for MHI SWIP channels.
> > >
> > Please add more info in the commit message i.e., why this interface is added and
> > how it is going to benefit the users etc..
> >
> > Since you are modifying the existing mhi_swip interface, this isn't an ABI
> > change?
> >
> > > Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
> > > Reviewed-by: Daniele Palmas <dnlplm@gmail.com>
> > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> > > ---
> > >
> > > changes since v1:
> > > - Moved to net-next from linux-next
> > > - moved to eth_hw_addr_random() to assign Ethernet MAC address
> > > from eth_random_addr()
> > > ---
> > > drivers/net/mhi_net.c | 53 ++++++++++++++++++++++++++++++++++++++-------------
> > > 1 file changed, 40 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
> > > index 3d322ac..5bb8d99 100644
> > > --- a/drivers/net/mhi_net.c
> > > +++ b/drivers/net/mhi_net.c
> > [...]
> >
> > > @@ -380,10 +405,12 @@ static void mhi_net_remove(struct mhi_device *mhi_dev)
> > > static const struct mhi_device_info mhi_hwip0 = {
> > > .netname = "mhi_hwip%d",
> > > + .ethernet_if = false,
> > > };
> > > static const struct mhi_device_info mhi_swip0 = {
> > > .netname = "mhi_swip%d",
> > > + .ethernet_if = false,
> > false?
> yes ,it is false as by default mhi_swip/mhi_hwip interface will be normal
> net device.
> >
> > - Mani
> >
> > > };
> > > static const struct mhi_device_id mhi_net_id_table[] = {
> > > --
> > > 2.7.4
> > >

--
மணிவண்ணன் சதாசிவம்