* [PATCH] scsi: ufs: qcom: remove unused variable
@ 2023-07-24 12:19 Arnd Bergmann
2023-07-24 12:31 ` Abel Vesa
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Arnd Bergmann @ 2023-07-24 12:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo
Cc: Arnd Bergmann, Asutosh Das, Andrew Halaney, Abel Vesa,
linux-arm-msm, linux-scsi, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent change removed the only user of a local variable that needs
to now also be removed:
drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ufs/host/ufs-qcom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 3ee5ff905f9a6..5728e94b6527b 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
struct msi_desc *desc = data;
struct device *dev = msi_desc_to_dev(desc);
struct ufs_hba *hba = dev_get_drvdata(dev);
- struct ufs_qcom_host *host = ufshcd_get_variant(hba);
u32 id = desc->msi_index;
struct ufs_hw_queue *hwq = &hba->uhq[id];
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unused variable
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
@ 2023-07-24 12:31 ` Abel Vesa
2023-07-24 13:06 ` Manivannan Sadhasivam
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2023-07-24 12:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo,
Arnd Bergmann, Asutosh Das, Andrew Halaney, linux-arm-msm,
linux-scsi, linux-kernel
On 23-07-24 14:19:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
>
> Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/ufs/host/ufs-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 3ee5ff905f9a6..5728e94b6527b 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
> struct msi_desc *desc = data;
> struct device *dev = msi_desc_to_dev(desc);
> struct ufs_hba *hba = dev_get_drvdata(dev);
> - struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> u32 id = desc->msi_index;
> struct ufs_hw_queue *hwq = &hba->uhq[id];
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unused variable
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
2023-07-24 12:31 ` Abel Vesa
@ 2023-07-24 13:06 ` Manivannan Sadhasivam
2023-07-25 21:53 ` Nick Desaulniers
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2023-07-24 13:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo,
Arnd Bergmann, Asutosh Das, Andrew Halaney, Abel Vesa,
linux-arm-msm, linux-scsi, linux-kernel
On Mon, Jul 24, 2023 at 02:19:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
>
> Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> drivers/ufs/host/ufs-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 3ee5ff905f9a6..5728e94b6527b 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
> struct msi_desc *desc = data;
> struct device *dev = msi_desc_to_dev(desc);
> struct ufs_hba *hba = dev_get_drvdata(dev);
> - struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> u32 id = desc->msi_index;
> struct ufs_hw_queue *hwq = &hba->uhq[id];
>
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unused variable
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
2023-07-24 12:31 ` Abel Vesa
2023-07-24 13:06 ` Manivannan Sadhasivam
@ 2023-07-25 21:53 ` Nick Desaulniers
2023-07-26 1:30 ` Martin K. Petersen
2023-07-31 19:45 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2023-07-25 21:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo,
Arnd Bergmann, Asutosh Das, Andrew Halaney, Abel Vesa,
linux-arm-msm, linux-scsi, linux-kernel, llvm
On Mon, Jul 24, 2023 at 02:19:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
>
> Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch!
Reported-by: kernelci.org bot <bot@kernelci.org>
Link: https://lore.kernel.org/llvm/64c00cd4.630a0220.6ad79.0eac@mx.google.com/
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/ufs/host/ufs-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 3ee5ff905f9a6..5728e94b6527b 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
> struct msi_desc *desc = data;
> struct device *dev = msi_desc_to_dev(desc);
> struct ufs_hba *hba = dev_get_drvdata(dev);
> - struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> u32 id = desc->msi_index;
> struct ufs_hw_queue *hwq = &hba->uhq[id];
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unused variable
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
` (2 preceding siblings ...)
2023-07-25 21:53 ` Nick Desaulniers
@ 2023-07-26 1:30 ` Martin K. Petersen
2023-07-31 19:45 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2023-07-26 1:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo,
Arnd Bergmann, Asutosh Das, Andrew Halaney, Abel Vesa,
linux-arm-msm, linux-scsi, linux-kernel
Arnd,
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unused variable
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
` (3 preceding siblings ...)
2023-07-26 1:30 ` Martin K. Petersen
@ 2023-07-31 19:45 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2023-07-31 19:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Ziqi Chen, Can Guo, Arnd Bergmann
Cc: Martin K . Petersen, Arnd Bergmann, Asutosh Das, Andrew Halaney,
Abel Vesa, linux-arm-msm, linux-scsi, linux-kernel
On Mon, 24 Jul 2023 14:19:58 +0200, Arnd Bergmann wrote:
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
>
>
> [...]
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: ufs: qcom: remove unused variable
https://git.kernel.org/mkp/scsi/c/65aca38b8ce7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-31 19:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-24 12:19 [PATCH] scsi: ufs: qcom: remove unused variable Arnd Bergmann
2023-07-24 12:31 ` Abel Vesa
2023-07-24 13:06 ` Manivannan Sadhasivam
2023-07-25 21:53 ` Nick Desaulniers
2023-07-26 1:30 ` Martin K. Petersen
2023-07-31 19:45 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).