Re: [PATCH] bus: mhi: host: pci_generic: Add support for Lenovo RM520N-GL

[Manivannan Sadhasivam <mani@kernel.org>]

On Thu, Jul 27, 2023 at 06:47:02PM -0700, Duke Xin(辛安文) wrote:

It is a Quectel modem, right? Then it should be mentioned as Quectel in subject.

> This modem is designed based on Qualcomm SDX6x and it will align with the quectel previous RM520N-GL modem settings.

s/it will align/works

s/quectel previous/Quectel's existing

> But this one is designed for lenovo laptop usecase, hence Quectel got a new PID.
> 

Also, wrap the commit message to 75 columns. And always run
./scripts/checkpatch.pl and fix warnings/errors before posting a patch.

- Mani

> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index fcd80bc92978..e4f2fb67dfaf 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -604,6 +604,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  	/* RM520N-GL (sdx6x), eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
> +	/* RM520N-GL (sdx6x), Lenovo variant */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1007),
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்