From: Manivannan Sadhasivam <mani@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Arnd Bergmann <arnd@arndb.de>, Tom Rix <trix@redhat.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Vivek Pernamitta <quic_vpernami@quicinc.com>,
Carl Vanderlip <quic_carlv@quicinc.com>,
Qiang Yu <quic_qianyu@quicinc.com>,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] bus: mhi: host: remove unused-but-set parameter
Date: Fri, 11 Aug 2023 20:36:44 +0530 [thread overview]
Message-ID: <20230811150644.GB5296@thinkpad> (raw)
In-Reply-To: <20230811134547.3231160-1-arnd@kernel.org>
On Fri, Aug 11, 2023 at 03:45:41PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Clang warns about a parameter that is decremented but never evaluated heere:
>
> bus/mhi/host/main.c:803:13: error: parameter 'event_quota' set but not used [-Werror,-Wunused-but-set-parameter]
> u32 event_quota)
>
> Remove the access to the variable to avoid that warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/host/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index 74a75439c7130..dcf627b36e829 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -938,7 +938,6 @@ int mhi_process_ctrl_ev_ring(struct mhi_controller *mhi_cntrl,
> if (!mhi_chan->configured)
> break;
> parse_xfer_event(mhi_cntrl, local_rp, mhi_chan);
> - event_quota--;
> }
> break;
> default:
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-08-11 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 13:45 [PATCH] bus: mhi: host: remove unused-but-set parameter Arnd Bergmann
2023-08-11 13:51 ` Jeffrey Hugo
2023-08-11 15:06 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811150644.GB5296@thinkpad \
--to=mani@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mhi@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).