* [PATCH] power: reset: qcom-pon: removed unneeded call to platform_set_drvdata()
@ 2023-08-14 18:18 Andrei Coardos
2023-08-14 19:43 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Coardos @ 2023-08-14 18:18 UTC (permalink / raw)
To: linux-kernel, linux-pm, linux-arm-msm
Cc: alex, sre, konrad.dybcio, andersson, agross, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/power/reset/qcom-pon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 1344b361a475..34478d60e2c1 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -80,8 +80,6 @@ static int pm8916_pon_probe(struct platform_device *pdev)
}
}
- platform_set_drvdata(pdev, pon);
-
return devm_of_platform_populate(&pdev->dev);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: removed unneeded call to platform_set_drvdata()
2023-08-14 18:18 [PATCH] power: reset: qcom-pon: removed unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-14 19:43 ` Bjorn Andersson
2023-08-15 12:04 ` Alexandru Ardelean
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2023-08-14 19:43 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-pm, linux-arm-msm, alex, sre, konrad.dybcio,
andersson, agross
On Mon, Aug 14, 2023 at 09:18:23PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: removed unneeded call to platform_set_drvdata()
2023-08-14 19:43 ` Bjorn Andersson
@ 2023-08-15 12:04 ` Alexandru Ardelean
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Ardelean @ 2023-08-15 12:04 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andrei Coardos, linux-kernel, linux-pm, linux-arm-msm, sre,
konrad.dybcio, andersson, agross
On Mon, Aug 14, 2023 at 10:43 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
>
> On Mon, Aug 14, 2023 at 09:18:23PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
> >
> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> Regards,
> Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-15 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-14 18:18 [PATCH] power: reset: qcom-pon: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-14 19:43 ` Bjorn Andersson
2023-08-15 12:04 ` Alexandru Ardelean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).