* [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
@ 2023-08-24 9:13 Yang Yingliang
2023-08-24 11:32 ` Varadarajan Narayanan
2023-09-21 14:26 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2023-08-24 9:13 UTC (permalink / raw)
To: linux-phy, linux-arm-msm; +Cc: quic_varada, andersson, vkoul, yangyingliang
It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.
Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
index ed08072ca032..99d570f4142a 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31.c
@@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
qphy->vreg = devm_regulator_get(dev, "vdda-phy");
if (IS_ERR(qphy->vreg))
- return dev_err_probe(dev, PTR_ERR(qphy->phy),
+ return dev_err_probe(dev, PTR_ERR(qphy->vreg),
"failed to get vreg\n");
phy_set_drvdata(qphy->phy, qphy);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
2023-08-24 9:13 [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() Yang Yingliang
@ 2023-08-24 11:32 ` Varadarajan Narayanan
2023-09-21 14:26 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Varadarajan Narayanan @ 2023-08-24 11:32 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-phy, linux-arm-msm, andersson, vkoul
On Thu, Aug 24, 2023 at 05:13:45PM +0800, Yang Yingliang wrote:
> It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.
>
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index ed08072ca032..99d570f4142a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>
> qphy->vreg = devm_regulator_get(dev, "vdda-phy");
> if (IS_ERR(qphy->vreg))
> - return dev_err_probe(dev, PTR_ERR(qphy->phy),
> + return dev_err_probe(dev, PTR_ERR(qphy->vreg),
> "failed to get vreg\n");
Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>
Thanks
Varada
>
> phy_set_drvdata(qphy->phy, qphy);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
2023-08-24 9:13 [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() Yang Yingliang
2023-08-24 11:32 ` Varadarajan Narayanan
@ 2023-09-21 14:26 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-09-21 14:26 UTC (permalink / raw)
To: linux-phy, linux-arm-msm, Yang Yingliang; +Cc: quic_varada, andersson
On Thu, 24 Aug 2023 17:13:45 +0800, Yang Yingliang wrote:
> It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.
>
>
Applied, thanks!
[1/1] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
commit: 5f7cd740a6b657fba775bde744496e5ed21851ca
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-21 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 9:13 [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() Yang Yingliang
2023-08-24 11:32 ` Varadarajan Narayanan
2023-09-21 14:26 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).