From: kernel test robot <lkp@intel.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH RFT 11/20] media: venus: core: Drop cache properties in resource struct
Date: Tue, 12 Sep 2023 07:53:27 +0800 [thread overview]
Message-ID: <202309120738.fip6vVJN-lkp@intel.com> (raw)
In-Reply-To: <20230911-topic-mars-v1-11-a7d38bf87bdb@linaro.org>
Hi Konrad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7bc675554773f09d88101bf1ccfc8537dc7c0be9]
url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/media-venus-pm_helpers-Only-set-rate-of-the-core-clock-in-core_clks_enable/20230912-051942
base: 7bc675554773f09d88101bf1ccfc8537dc7c0be9
patch link: https://lore.kernel.org/r/20230911-topic-mars-v1-11-a7d38bf87bdb%40linaro.org
patch subject: [PATCH RFT 11/20] media: venus: core: Drop cache properties in resource struct
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230912/202309120738.fip6vVJN-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120738.fip6vVJN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309120738.fip6vVJN-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/qcom/venus/hfi_venus.c: In function 'venus_isr_thread':
>> drivers/media/platform/qcom/venus/hfi_venus.c:1060:39: warning: variable 'res' set but not used [-Wunused-but-set-variable]
1060 | const struct venus_resources *res;
| ^~~
vim +/res +1060 drivers/media/platform/qcom/venus/hfi_venus.c
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1056
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1057 static irqreturn_t venus_isr_thread(struct venus_core *core)
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1058 {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1059 struct venus_hfi_device *hdev = to_hfi_priv(core);
4cb3548a87c4a3 Stanimir Varbanov 2017-06-15 @1060 const struct venus_resources *res;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1061 void *pkt;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1062 u32 msg_ret;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1063
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1064 if (!hdev)
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1065 return IRQ_NONE;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1066
4cb3548a87c4a3 Stanimir Varbanov 2017-06-15 1067 res = hdev->core->res;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1068 pkt = hdev->pkt_buf;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1069
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1070
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1071 while (!venus_iface_msgq_read(hdev, pkt)) {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1072 msg_ret = hfi_process_msg_packet(core, pkt);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1073 switch (msg_ret) {
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1074 case HFI_MSG_EVENT_NOTIFY:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1075 venus_process_msg_sys_error(hdev, pkt);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1076 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1077 case HFI_MSG_SYS_INIT:
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1078 /* Disable OCMEM/VMEM unconditionally until support is added */
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1079 venus_hfi_core_set_resource(core, VIDC_RESOURCE_NONE,
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1080 0,
8b05e503e6c2dd Konrad Dybcio 2023-09-11 1081 0,
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1082 hdev);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1083 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1084 case HFI_MSG_SYS_RELEASE_RESOURCE:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1085 complete(&hdev->release_resource);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1086 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1087 case HFI_MSG_SYS_PC_PREP:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1088 complete(&hdev->pwr_collapse_prep);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1089 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1090 default:
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1091 break;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1092 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1093 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1094
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1095 venus_flush_debug_queue(hdev);
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1096
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1097 return IRQ_HANDLED;
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1098 }
d96d3f30c0f2f5 Stanimir Varbanov 2017-06-15 1099
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-12 1:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:10 [PATCH RFT 00/20] Venus cleanups Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 01/20] media: venus: pm_helpers: Only set rate of the core clock in core_clks_enable Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 02/20] media: venus: pm_helpers: Rename core_clks_get to venus_clks_get Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 03/20] media: venus: pm_helpers: Add kerneldoc to venus_clks_get() Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 04/20] media: venus: core: Set OPP clkname in a common code path Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 05/20] media: venus: pm_helpers: Kill dead code Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 06/20] media: venus: pm_helpers: Move reset acquisition to common code Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 07/20] media: venus: pm_helpers: Use reset_bulk API Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 08/20] media: venus: core: Constify all members of the resource struct Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 09/20] media: venus: core: Deduplicate OPP genpd names Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 10/20] media: venus: core: Get rid of vcodec_num Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 11/20] media: venus: core: Drop cache properties in resource struct Konrad Dybcio
2023-09-11 23:53 ` kernel test robot [this message]
2023-09-11 15:10 ` [PATCH RFT 12/20] media: venus: core: Use GENMASK for dma_mask Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 13/20] media: venus: core: Remove cp_start Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 14/20] media: venus: pm_helpers: Commonize core_power Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 15/20] media: venus: pm_helpers: Remove pm_ops->core_put Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 16/20] media: venus: core: Define a pointer to core->res Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 17/20] media: venus: pm_helpers: Simplify vcodec clock handling Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 18/20] media: venus: pm_helpers: Commonize getting clocks and GenPDs Konrad Dybcio
2023-09-11 15:10 ` [PATCH RFT 19/20] media: venus: pm_helpers: Commonize vdec_get() Konrad Dybcio
2023-09-13 3:52 ` kernel test robot
2023-09-11 15:10 ` [PATCH RFT 20/20] media: venus: pm_helpers: Commonize venc_get() Konrad Dybcio
2023-09-13 11:24 ` kernel test robot
2023-09-12 6:19 ` [PATCH RFT 00/20] Venus cleanups Bryan O'Donoghue
2023-09-13 12:03 ` Konrad Dybcio
2023-09-13 12:26 ` Bryan O'Donoghue
2023-09-15 14:13 ` Bryan O'Donoghue
2023-09-15 14:15 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309120738.fip6vVJN-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox