Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ekansh Gupta <quic_ekangupt@quicinc.com>
Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org,
	ekangupt@qti.qualcomm.com, linux-kernel@vger.kernel.org,
	fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH v3 1/5] misc: fastrpc: Add fastrpc multimode invoke request support
Date: Thu, 28 Sep 2023 15:07:11 +0200	[thread overview]
Message-ID: <2023092840-rental-ascension-b062@gregkh> (raw)
In-Reply-To: <1695206827-29446-2-git-send-email-quic_ekangupt@quicinc.com>

On Wed, Sep 20, 2023 at 04:17:03PM +0530, Ekansh Gupta wrote:
> Multimode invocation request is intended to support multiple
> different type of requests. This will include enhanced invoke
> request to support CRC check and performance counter enablement.
> This will also support few driver level user controllable
> mechanisms like usage of shared context banks, wakelock support,
> etc. This IOCTL is also added with the aim to support few
> new fastrpc features like DSP PD notification framework,
> DSP Signalling mechanism etc.

I can't see where you are properly checking the reserved fields in your
new ioctl structures, am I just missing that logic somewhere?

thanks,

greg k-h

  parent reply	other threads:[~2023-09-28 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 10:47 [PATCH v3 0/5] Add multimode invoke request IOCTl support Ekansh Gupta
2023-09-20 10:47 ` [PATCH v3 1/5] misc: fastrpc: Add fastrpc multimode invoke request support Ekansh Gupta
2023-09-20 19:06   ` kernel test robot
2023-09-28 13:07   ` Greg KH [this message]
2023-09-20 10:47 ` [PATCH v3 2/5] misc: fastrpc: Add CRC support for remote buffers Ekansh Gupta
2023-09-20 10:47 ` [PATCH v3 3/5] misc: fastrpc: Capture kernel and DSP performance counters Ekansh Gupta
2023-09-20 10:47 ` [PATCH v3 4/5] misc: fastrpc: Add support to save and restore interrupted Ekansh Gupta
2023-09-20 10:47 ` [PATCH v3 5/5] misc: fastrpc: Add support to allocate shared context bank Ekansh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023092840-rental-ascension-b062@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ekangupt@qti.qualcomm.com \
    --cc=fastrpc.upstream@qti.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_ekangupt@quicinc.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox