From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F3BE81E0D for ; Fri, 6 Oct 2023 15:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232570AbjJFPkl (ORCPT ); Fri, 6 Oct 2023 11:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbjJFPkk (ORCPT ); Fri, 6 Oct 2023 11:40:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2641AD; Fri, 6 Oct 2023 08:40:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACBADC433C8; Fri, 6 Oct 2023 15:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696606838; bh=CQ3tpC/DASTgxY6DDz8rdDHkbS+6W3r8KCIgNsOPPFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EkEDsXAQ9Cmp5tr6OX02yztvXuEbocstBiOPRzphvHadTQWhWYleaSZbvu1wtGs01 6nOTIj6d39Wf9f2O3HU4RtDsg5ZmWVZ1pr95jki4nCbdvq12awFJOQrVBG5caz9bJv XJEyH23/Gz6FBn5DgXZLUxjzVEYrMw04vNqmb9eg0rYxc15KWZXl5/9Jw47i3Vtyh+ KSbT25eci1dJbo4kHPGWNi49TRMNUugOMtRhj2iW607HMXC5U4mlWQyKrswjRm+zUP /DLDKIkAf1PjodlsEqrnEG0fk/TgHo/Esmy70ObjBZxOryVStJX90YPdVdMHklQF/X USLsmjTvRBvZQ== Received: (nullmailer pid 3983540 invoked by uid 1000); Fri, 06 Oct 2023 15:40:35 -0000 Date: Fri, 6 Oct 2023 10:40:35 -0500 From: Rob Herring To: Neil Armstrong Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/4] dt-bindings: soc: qcom: qcom,pmic-glink: add a gpio used to determine the Type-C port plug orientation Message-ID: <20231006154035.GA3979654-robh@kernel.org> References: <20231002-topic-sm8550-upstream-type-c-orientation-v2-0-125410d3ff95@linaro.org> <20231002-topic-sm8550-upstream-type-c-orientation-v2-1-125410d3ff95@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002-topic-sm8550-upstream-type-c-orientation-v2-1-125410d3ff95@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Oct 02, 2023 at 12:20:21PM +0200, Neil Armstrong wrote: > On SM8450 and SM8550 based platforms, the Type-C plug orientation is given on a > GPIO line for each connector which are set by the PMIC(s). > > Document this optional Type-C connector property, and take the > assumption an active level represents an inverted/flipped orientation. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml > index bceb479f74c5..422921cf1f82 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml > @@ -35,6 +35,12 @@ properties: > '#size-cells': > const: 0 > > + orientation-gpios: > + description: Array of input gpios for the Type-C connector orientation indication. > + The GPIO indication is used to detect the orientation of the Type-C connector. > + The array should contain a gpio entry for each PMIC Glink connector, in reg order. > + It is defined that GPIO active level means "CC2" or Reversed/Flipped orientation. Shouldn't this node then have 'orientation-switch'?