From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, bhelgaas@google.com,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, abel.vesa@linaro.org
Subject: Re: [PATCH v4 1/3] PCI: qcom: Use PCIE_SPEED2MBS_ENC() macro for encoding link speed
Date: Sun, 15 Oct 2023 04:32:19 +0900 [thread overview]
Message-ID: <20231014193219.GA1190809@rocinante> (raw)
In-Reply-To: <20231004164430.39662-1-manivannan.sadhasivam@linaro.org>
Hello,
> Instead of hardcoding the link speed in MBps, use existing
> PCIE_SPEED2MBS_ENC() macro that does the encoding of the link speed for us.
> Also, let's Wrap it with QCOM_PCIE_LINK_SPEED_TO_BW() macro to do the
> conversion to ICC speed.
>
> This eliminates the need for a switch case in qcom_pcie_icc_update() and
> also works for future Gen speeds without any code modifications.
[...]
Applied to controller/speed, thank you!
[1/3] PCI: qcom: Use PCIE_SPEED2MBS_ENC() macro for encoding link speed
https://git.kernel.org/pci/pci/c/8da2e9af0bb5
[2/3] PCI: qcom-ep: Use PCIE_SPEED2MBS_ENC() macro for encoding link speed
https://git.kernel.org/pci/pci/c/dc2f2a9d1cf2
[3/3] PCI: tegra194: Use Mbps_to_icc() macro for setting icc speed
https://git.kernel.org/pci/pci/c/85e9eb3e7727
Krzysztof
prev parent reply other threads:[~2023-10-14 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 16:44 [PATCH v4 1/3] PCI: qcom: Use PCIE_SPEED2MBS_ENC() macro for encoding link speed Manivannan Sadhasivam
2023-10-04 16:44 ` [PATCH v4 2/3] PCI: qcom-ep: " Manivannan Sadhasivam
2023-10-06 21:17 ` Konrad Dybcio
2023-10-04 16:44 ` [PATCH v4 3/3] PCI: tegra194: Use Mbps_to_icc() macro for setting icc speed Manivannan Sadhasivam
2023-10-06 21:18 ` Konrad Dybcio
2023-10-06 21:17 ` [PATCH v4 1/3] PCI: qcom: Use PCIE_SPEED2MBS_ENC() macro for encoding link speed Konrad Dybcio
2023-10-14 19:32 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014193219.GA1190809@rocinante \
--to=kw@linux.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox